You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/25 03:40:09 UTC

[GitHub] [shardingsphere] zhaolin81 opened a new pull request #5775: Update EncryptTable

zhaolin81 opened a new pull request #5775:
URL: https://github.com/apache/shardingsphere/pull/5775


   fixed when logicColumn is lowercase, findOriginLogicColumnName func will return Empty。
   
   Fixes #5774
   
   Changes proposed in this pull request:
   -
   -
   -
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5775: Update EncryptTable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5775:
URL: https://github.com/apache/shardingsphere/pull/5775#issuecomment-633364941


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=h1) Report
   > Merging [#5775](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0fbf7d7c4ccca5c854aa8ba43b8f17c5c9d2c357&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5775/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5775   +/-   ##
   =========================================
     Coverage     53.04%   53.04%           
     Complexity      437      437           
   =========================================
     Files          1178     1178           
     Lines         20721    20722    +1     
     Branches       3736     3736           
   =========================================
   + Hits          10991    10992    +1     
     Misses         9059     9059           
     Partials        671      671           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../shardingsphere/encrypt/strategy/EncryptTable.java](https://codecov.io/gh/apache/shardingsphere/pull/5775/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9zdHJhdGVneS9FbmNyeXB0VGFibGUuamF2YQ==) | `81.81% <50.00%> (+0.42%)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=footer). Last update [0fbf7d7...0dd23d8](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaolin81 commented on a change in pull request #5775: Update EncryptTable

Posted by GitBox <gi...@apache.org>.
zhaolin81 commented on a change in pull request #5775:
URL: https://github.com/apache/shardingsphere/pull/5775#discussion_r429765866



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/strategy/EncryptTable.java
##########
@@ -119,7 +119,9 @@ public String getCipherColumn(final String logicColumn) {
      * @return assisted query column
      */
     public Optional<String> findAssistedQueryColumn(final String logicColumn) {
-        return columns.containsKey(logicColumn) ? columns.get(logicColumn).getAssistedQueryColumn() : Optional.empty();
+        //return columns.containsKey(logicColumn) ? columns.get(logicColumn).getAssistedQueryColumn() : Optional.empty();

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaolin81 commented on a change in pull request #5775: Update EncryptTable

Posted by GitBox <gi...@apache.org>.
zhaolin81 commented on a change in pull request #5775:
URL: https://github.com/apache/shardingsphere/pull/5775#discussion_r429768771



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/strategy/EncryptTable.java
##########
@@ -119,7 +119,9 @@ public String getCipherColumn(final String logicColumn) {
      * @return assisted query column
      */
     public Optional<String> findAssistedQueryColumn(final String logicColumn) {
-        return columns.containsKey(logicColumn) ? columns.get(logicColumn).getAssistedQueryColumn() : Optional.empty();
+        //return columns.containsKey(logicColumn) ? columns.get(logicColumn).getAssistedQueryColumn() : Optional.empty();

Review comment:
       comments removed 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #5775: Update EncryptTable

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5775:
URL: https://github.com/apache/shardingsphere/pull/5775#discussion_r429765315



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/strategy/EncryptTable.java
##########
@@ -119,7 +119,9 @@ public String getCipherColumn(final String logicColumn) {
      * @return assisted query column
      */
     public Optional<String> findAssistedQueryColumn(final String logicColumn) {
-        return columns.containsKey(logicColumn) ? columns.get(logicColumn).getAssistedQueryColumn() : Optional.empty();
+        //return columns.containsKey(logicColumn) ? columns.get(logicColumn).getAssistedQueryColumn() : Optional.empty();

Review comment:
       remove this comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5775: Update EncryptTable

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5775:
URL: https://github.com/apache/shardingsphere/pull/5775#issuecomment-633364941


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=h1) Report
   > Merging [#5775](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0fbf7d7c4ccca5c854aa8ba43b8f17c5c9d2c357&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5775/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5775   +/-   ##
   =========================================
     Coverage     53.04%   53.04%           
     Complexity      437      437           
   =========================================
     Files          1178     1178           
     Lines         20721    20722    +1     
     Branches       3736     3736           
   =========================================
   + Hits          10991    10992    +1     
     Misses         9059     9059           
     Partials        671      671           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../shardingsphere/encrypt/strategy/EncryptTable.java](https://codecov.io/gh/apache/shardingsphere/pull/5775/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9zdHJhdGVneS9FbmNyeXB0VGFibGUuamF2YQ==) | `81.81% <50.00%> (+0.42%)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=footer). Last update [0fbf7d7...6375701](https://codecov.io/gh/apache/shardingsphere/pull/5775?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking merged pull request #5775: Update EncryptTable

Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5775:
URL: https://github.com/apache/shardingsphere/pull/5775


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org