You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/08 21:26:55 UTC

[GitHub] [arrow] aucahuasi commented on a diff in pull request #14077: ARROW-16870: [C++] Fix link issues with ldd and clang for flight examples

aucahuasi commented on code in PR #14077:
URL: https://github.com/apache/arrow/pull/14077#discussion_r966435613


##########
cpp/examples/arrow/CMakeLists.txt:
##########
@@ -36,10 +36,14 @@ if(ARROW_FLIGHT)
   # we'll violate ODR for gRPC symbols
   if(ARROW_GRPC_USE_SHARED)
     set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_shared)
-    # We don't directly use symbols from the reflection library, so
-    # ensure the linker still links to it
-    set(GRPC_REFLECTION_LINK_LIBS -Wl,--no-as-needed gRPC::grpc++_reflection
-                                  -Wl,--as-needed)
+    if(APPLE)

Review Comment:
   Good point, let me check, I'll use docker for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org