You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/06/28 21:40:14 UTC

[GitHub] [lucene-solr] mkhludnev opened a new pull request #1628: SOLR-14539: Ref Guide changes

mkhludnev opened a new pull request #1628:
URL: https://github.com/apache/lucene-solr/pull/1628


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] mkhludnev closed pull request #1628: SOLR-14539: Ref Guide changes

Posted by GitBox <gi...@apache.org>.
mkhludnev closed pull request #1628:
URL: https://github.com/apache/lucene-solr/pull/1628


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] ctargett commented on a change in pull request #1628: SOLR-14539: Ref Guide changes

Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #1628:
URL: https://github.com/apache/lucene-solr/pull/1628#discussion_r447049307



##########
File path: solr/solr-ref-guide/src/json-query-dsl.adoc
##########
@@ -303,6 +303,30 @@ include::{example-source-dir}JsonRequestApiTest.java[tag=solrj-ipod-query-bool-c
 ====
 --
 
+Example of referencing <<json-query-dsl.adoc#additional-queries>>, <<json-query-dsl.adoc#tagging-in-json-query-dsl,tagging>> and <<other-parsers.adoc#boolean-query-parser,exclusions>>:

Review comment:
       The syntax for a link to a section that's on the same page is to simply use the section title, so:
   
   - `<<json-query-dsl.adoc#additional-queries>>` should become `<<Additional Queries>>`
   - `<<json-query-dsl.adoc#tagging-in-json-query-dsl,tagging>>` should become `<<Tagging in JSON Query DSL,tagging>>`
   
   If you don't want the first one to be printed as "Additional Queries" (capitalized), you can add the link text as in the 2nd example




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] mkhludnev commented on pull request #1628: SOLR-14539: Ref Guide changes

Posted by GitBox <gi...@apache.org>.
mkhludnev commented on pull request #1628:
URL: https://github.com/apache/lucene-solr/pull/1628#issuecomment-652634407


   Merged to 8.6.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org