You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/05/04 03:23:20 UTC

[Bug 54926] New: WsFilter performs handshake validation even if it doesn't have a mapped endpoint

https://issues.apache.org/bugzilla/show_bug.cgi?id=54926

            Bug ID: 54926
           Summary: WsFilter performs handshake validation even if it
                    doesn't have a mapped endpoint
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: rstoyanchev@yahoo.com
    Classification: Unclassified

WsFilter performs several validations on WebSocket requests before checking if
there is a registered Endpoint. I think the check for registered Endponts (and
delegation to the next Filter) should take place first and the filter should do
no further processing if there is mapped Endpoint for that URL.

For example a SockJS protocol test send a POST request with a connection and
upgrade headers but no ws version header and expects back a 405 (invalid HTTP
method) where WsFilter sends 426 even though it has no Endpoint mapped at that
URL.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 54926] WsFilter performs handshake validation even if it doesn't have a mapped endpoint

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54926

--- Comment #1 from rstoyanchev@yahoo.com ---
Typo above. I meant to write "if there is *no* mapped Endpoint".

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 54926] WsFilter performs handshake validation even if it doesn't have a mapped endpoint

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54926

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
RFC 6455 puts checking for a matching URI earlier in the list of checks too.

The change has been applied to trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org