You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/01 11:06:37 UTC

[GitHub] leventov commented on issue #6942: Shade Guava manually

leventov commented on issue #6942: Shade Guava manually
URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-459687733
 
 
   To me it seems that there is a problem with Charles's approach (in #6948 and #6815) (also we have `Closer` and maybe some other classes copied from Guava already): this is very ad-hoc, each class is copied independently. There is no list of them all. Each class should be updated in separation. The likely result is that we probably won't update them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org