You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/06 17:03:08 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10089:
[FLINK-12342][yarn] Remove container requests in order to reduce excess
containers
tillrohrmann commented on a change in pull request #10089: [FLINK-12342][yarn] Remove container requests in order to reduce excess containers
URL: https://github.com/apache/flink/pull/10089#discussion_r343215946
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -370,45 +370,24 @@ public void onContainersCompleted(final List<ContainerStatus> statuses) {
@Override
public void onContainersAllocated(List<Container> containers) {
runAsync(() -> {
Review comment:
For this, we need to read `numPendingContainerRequests` which can only be done from within the actor's main thread. Hence without introducing some `volatiles` and potential race conditions I don't see an easy way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services