You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/05/02 04:45:15 UTC

Review Request: Adjusted the sched.cpp log levels based on importance.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10900/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Bill Farner.


Description
-------

Based on data from an internal framework at Twitter:

$ grep sched.cpp framework.log | cut -d']' -f1 | awk '{print $NF}' | sort | uniq -c
  10641 sched.cpp:282
  32729 sched.cpp:327
      1 sched.cpp:384
      5 sched.cpp:401

I0502 00:05:07.885108 31669 sched.cpp:282] Received 3 offers

I0502 00:05:08.549502 31677 sched.cpp:327] Status update: task FOO of framework BAR is now in state TASK_FAILED


Diffs
-----

  src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 

Diff: https://reviews.apache.org/r/10900/diff/


Testing
-------

None.


Thanks,

Ben Mahler

Re: Review Request: Adjusted the sched.cpp log levels based on importance.

Posted by Bill Farner <bi...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10900/#review20047
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On May 2, 2013, 2:45 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10900/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 2:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Bill Farner.
> 
> 
> Description
> -------
> 
> Based on data from an internal framework at Twitter:
> 
> $ grep sched.cpp framework.log | cut -d']' -f1 | awk '{print $NF}' | sort | uniq -c
>   10641 sched.cpp:282
>   32729 sched.cpp:327
>       1 sched.cpp:384
>       5 sched.cpp:401
> 
> I0502 00:05:07.885108 31669 sched.cpp:282] Received 3 offers
> 
> I0502 00:05:08.549502 31677 sched.cpp:327] Status update: task FOO of framework BAR is now in state TASK_FAILED
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
> 
> Diff: https://reviews.apache.org/r/10900/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Adjusted the sched.cpp log levels based on importance.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10900/#review20090
-----------------------------------------------------------


lets also put storm people on the review to gather more view points.


src/sched/sched.cpp
<https://reviews.apache.org/r/10900/#comment41328>

    s/1/2/ ?



src/sched/sched.cpp
<https://reviews.apache.org/r/10900/#comment41329>

    ditto



src/sched/sched.cpp
<https://reviews.apache.org/r/10900/#comment41330>

    ditto


- Vinod Kone


On May 2, 2013, 2:45 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10900/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 2:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Bill Farner.
> 
> 
> Description
> -------
> 
> Based on data from an internal framework at Twitter:
> 
> $ grep sched.cpp framework.log | cut -d']' -f1 | awk '{print $NF}' | sort | uniq -c
>   10641 sched.cpp:282
>   32729 sched.cpp:327
>       1 sched.cpp:384
>       5 sched.cpp:401
> 
> I0502 00:05:07.885108 31669 sched.cpp:282] Received 3 offers
> 
> I0502 00:05:08.549502 31677 sched.cpp:327] Status update: task FOO of framework BAR is now in state TASK_FAILED
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
> 
> Diff: https://reviews.apache.org/r/10900/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Adjusted the sched.cpp log levels based on importance.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10900/
-----------------------------------------------------------

(Updated May 2, 2013, 7:35 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Vinod's review.


Description (updated)
-------

Since everything is VLOG, I had the following in mind for levels:
  1: Important things, including errors.
  2: Information expected during normal operation.
  3: Additional information for debugging.

Based on data from an internal framework at Twitter:
$ grep sched.cpp framework.log | cut -d']' -f1 | awk '{print $NF}' | sort | uniq -c
  10641 sched.cpp:282
  32729 sched.cpp:327
      1 sched.cpp:384
      5 sched.cpp:401

I0502 00:05:07.885108 31669 sched.cpp:282] Received 3 offers
I0502 00:05:08.549502 31677 sched.cpp:327] Status update: task FOO of framework BAR is now in state TASK_FAILED


Diffs (updated)
-----

  src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 

Diff: https://reviews.apache.org/r/10900/diff/


Testing
-------

None.


Thanks,

Ben Mahler