You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/06 23:34:53 UTC
[GitHub] [beam] y1chi commented on a diff in pull request #17271: Factors enable_prime flag in when checking use_unified_worker conditions
y1chi commented on code in PR #17271:
URL: https://github.com/apache/beam/pull/17271#discussion_r844515506
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -1174,11 +1174,22 @@ def _use_unified_worker(pipeline_options):
debug_options = pipeline_options.view_as(DebugOptions)
use_unified_worker_flag = 'use_unified_worker'
use_runner_v2_flag = 'use_runner_v2'
+ enable_prime_flag = 'enable_prime'
if (debug_options.lookup_experiment(use_runner_v2_flag) and
not debug_options.lookup_experiment(use_unified_worker_flag)):
debug_options.add_experiment(use_unified_worker_flag)
+ dataflow_service_options = pipeline_options.view_as(
Review Comment:
Done. I don't see any mention of disable_unified_worker so only added check for disable_runner_v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org