You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Benedikt Ritter (Created) (JIRA)" <ji...@apache.org> on 2012/03/10 17:34:58 UTC

[jira] [Created] (FELIX-3382) Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch

Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch
--------------------------------------------------------------------------------------------------------

                 Key: FELIX-3382
                 URL: https://issues.apache.org/jira/browse/FELIX-3382
             Project: Felix
          Issue Type: Improvement
            Reporter: Benedikt Ritter
            Priority: Trivial


Apply the same changes to the servicebased SimpleShape example as described in FELIX-3379 for the extenderbased SimpleShape example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FELIX-3382) Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch

Posted by "Richard S. Hall (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228535#comment-13228535 ] 

Richard S. Hall commented on FELIX-3382:
----------------------------------------

I've applied your patches, they looked ok to me.

Regarding your questions:

1. Actually, framework.jar embeds the OSGi packages and main.jar embeds all of framework.jar. Mainly so we can customize some OSGi classes that have implementations and so we can have a self-contained framework.

2. I believe that is correct, since we are not transforming the objects, see: http://njbartlett.name/2010/08/10/generic-osgi.html

Please close this issue if you are satisfied. Thanks.
                
> Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch
> --------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3382
>                 URL: https://issues.apache.org/jira/browse/FELIX-3382
>             Project: Felix
>          Issue Type: Improvement
>            Reporter: Benedikt Ritter
>            Priority: Trivial
>         Attachments: FELIX-3382_circle.txt, FELIX-3382_host.txt, FELIX-3382_square.txt, FELIX-3382_trapezoid.txt, FELIX-3382_triangle.txt
>
>
> Apply the same changes to the servicebased SimpleShape example as described in FELIX-3379 for the extenderbased SimpleShape example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FELIX-3382) Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch

Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter updated FELIX-3382:
-----------------------------------

    Attachment: FELIX-3382_triangle.txt
                FELIX-3382_trapezoid.txt
                FELIX-3382_square.txt
                FELIX-3382_host.txt
                FELIX-3382_circle.txt

I've attached a patch for this issue. Summary:

* added Application.java and ConfigUtil.java to the host
* updated the host's pom to use Java 1.6 and Felix 4.0.2
* deleted dependency to org.osgi in all bundles (Felix brings that)

There are two things I'm interested in:
1. why does the felix.main artifact include the org.osgi.* packages, rather then defining a dependency?
2. Did I modify the ShapeTracker correctly? ShapeTracker extends ServiceTracker<SimpleShape, SimpleShape> does look a bit strange.

Regards and TIA for reviewing,
Benedikt
                
> Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch
> --------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3382
>                 URL: https://issues.apache.org/jira/browse/FELIX-3382
>             Project: Felix
>          Issue Type: Improvement
>            Reporter: Benedikt Ritter
>            Priority: Trivial
>         Attachments: FELIX-3382_circle.txt, FELIX-3382_host.txt, FELIX-3382_square.txt, FELIX-3382_trapezoid.txt, FELIX-3382_triangle.txt
>
>
> Apply the same changes to the servicebased SimpleShape example as described in FELIX-3379 for the extenderbased SimpleShape example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (FELIX-3382) Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch

Posted by "Benedikt Ritter (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter closed FELIX-3382.
----------------------------------

    Resolution: Fixed

Thanks for the review and the answers!
                
> Update servicebased SimpleShapes example to create an embedded framework using org.osgi.framework.launch
> --------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3382
>                 URL: https://issues.apache.org/jira/browse/FELIX-3382
>             Project: Felix
>          Issue Type: Improvement
>            Reporter: Benedikt Ritter
>            Priority: Trivial
>         Attachments: FELIX-3382_circle.txt, FELIX-3382_host.txt, FELIX-3382_square.txt, FELIX-3382_trapezoid.txt, FELIX-3382_triangle.txt
>
>
> Apply the same changes to the servicebased SimpleShape example as described in FELIX-3379 for the extenderbased SimpleShape example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira