You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/21 16:50:00 UTC

[jira] [Commented] (PROTON-1916) Makes StringsBenchmark::encodeStringMessage GC free

    [ https://issues.apache.org/jira/browse/PROTON-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587720#comment-16587720 ] 

ASF GitHub Bot commented on PROTON-1916:
----------------------------------------

GitHub user franz1981 opened a pull request:

    https://github.com/apache/qpid-proton-j/pull/15

    PROTON-1916: Makes StringsBenchmark::encodeStringMessage GC free

    It includes a perf improvement on string encoding to simplify
    the JVM work to compute bounds checking by using a specific
    implementation of string encoding for heap ByteBuffers

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/qpid-proton-j PROTON-1916

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton-j/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 24f46a124951c8b45ec6a8c67ab1adc1b07c41d7
Author: Francesco Nigro <ni...@...>
Date:   2018-08-21T16:21:59Z

    PROTON-1916: Makes StringsBenchmark::encodeStringMessage GC free
    
    It includes a perf improvement on string encoding to simplify
    the JVM work to compute bounds checking by using a specific
    implementation of string encoding for heap ByteBuffers

----


> Makes StringsBenchmark::encodeStringMessage GC free
> ---------------------------------------------------
>
>                 Key: PROTON-1916
>                 URL: https://issues.apache.org/jira/browse/PROTON-1916
>             Project: Qpid Proton
>          Issue Type: Improvement
>            Reporter: Francesco Nigro
>            Priority: Trivial
>             Fix For: proton-j-0.30.0
>
>
> StringsBenchmark is allocating a new ByteBufferWrapper instance
> on each encodeStringMessage invocation, making the encoding results depending by
> the amount of garbage produced: turning the benchmark GC free will allow to obtain more
> stable results and focus just on the String encoding speed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org