[GitHub] [dubbo] xulingfeng931027 opened pull request #5909: Fix a redundant judgment code

["xulingfeng931027 (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

去掉代码里多余的一次判断
## Brief changelog

第一次进入for循环的时候会进入 if (leastActive == -1 || active < leastActive) 里面 因为leastActive 初始值为-1 , 进入else if (active == leastActive)逻辑时上面for循环的i肯定是大于0的,因此无需判断i>0了.

## Verifying this change
原有的单元逻辑都能通过.

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/dubbo/pull/5909 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] xulingfeng931027 commented on issue #5909: Fix a redundant judgment code

["xulingfeng931027 (GitHub)" <gi...@apache.org>]

So the first time you go into the for loop you're going to go into the if (leastActive == -1 || active < leastActive) because leastActive starts at negative 1, and then if you go into the else if (active == leastActive) logic the I of the for loop is definitely greater than 0, so you don't have to say I >0.

[ Full content available at: https://github.com/apache/dubbo/pull/5909 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org