[GitHub] [spark] viirya commented on a change in pull request #24249: [SPARK-27325][SQL] Add implicit encoders for LocalDate and Instant

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24249: [SPARK-27325][SQL] Add implicit encoders for LocalDate and Instant
URL: https://github.com/apache/spark/pull/24249#discussion_r270655782
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala
 ##########
 @@ -109,13 +109,29 @@ object Encoders {
    */
   def DATE: Encoder[java.sql.Date] = ExpressionEncoder()
 
+  /**
+   * Creates an encoder that serializes instances of the `java.time.LocalDate` class
+   * to the internal representation of Catalyst's DateType.
 
 Review comment:
   `DATE` and `TIMESTAMP` encoders' comments mention the nullability. Shall we also mention it here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org