You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jim Jagielski <ji...@jaguNET.com> on 2011/10/25 19:00:59 UTC
Re: svn commit: r1186545 - /httpd/httpd/trunk/server/mpm/simple/simple_io.c
These types of things exist for a reason. Please don't
remove them…
On Oct 19, 2011, at 6:40 PM, sf@apache.org wrote:
> Author: sf
> Date: Wed Oct 19 22:40:06 2011
> New Revision: 1186545
>
> URL: http://svn.apache.org/viewvc?rev=1186545&view=rev
> Log:
> Comment out some incomplete code that does nothing but produce a compiler
> warning
>
> Modified:
> httpd/httpd/trunk/server/mpm/simple/simple_io.c
>
> Modified: httpd/httpd/trunk/server/mpm/simple/simple_io.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/simple/simple_io.c?rev=1186545&r1=1186544&r2=1186545&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/mpm/simple/simple_io.c (original)
> +++ httpd/httpd/trunk/server/mpm/simple/simple_io.c Wed Oct 19 22:40:06 2011
> @@ -31,12 +31,14 @@ APLOG_USE_MODULE(mpm_simple);
>
> static void simple_io_timeout_cb(simple_core_t * sc, void *baton)
> {
> +#if 0
> simple_conn_t *scon = (simple_conn_t *) baton;
> /* pqXXXXX: handle timeouts. */
> conn_rec *c = scon->c;
> conn_state_t *cs = c->cs;
>
> cs = NULL;
> +#endif
>
> ap_log_error(APLOG_MARK, APLOG_WARNING, 0, ap_server_conf,
> "io timeout hit (?)");
>
>
Re: svn commit: r1186545 - /httpd/httpd/trunk/server/mpm/simple/simple_io.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Oct 25, 2011, at 1:39 PM, William A. Rowe Jr. wrote:
> On 10/25/2011 12:00 PM, Jim Jagielski wrote:
>> These types of things exist for a reason. Please don't
>> remove them…
>
> Nobody left a comment to explain why it was left dangling,
> and it does nothing.
>
>
/* pqXXXXX: handle timeouts. */
I thought we wanted code that was ez to read and take up
on. The #ifdef shows clearly what that section of code
is supposed to do, but doesn't and serves as an invitation
to someone to fix it.
Remove it and all that is lost.
Re: svn commit: r1186545 - /httpd/httpd/trunk/server/mpm/simple/simple_io.c
Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 10/25/2011 12:39 PM, William A. Rowe Jr. wrote:
> On 10/25/2011 12:00 PM, Jim Jagielski wrote:
>> These types of things exist for a reason. Please don't
>> remove them…
>
> Nobody left a comment to explain why it was left dangling,
> and it does nothing.
>
> +1 - remove it.
>
> http://badprogrammer.infogami.com/ ... c.f. Collyer Brothers syndrome
Or more to the point... if you follow Jim's request to leave it handy,
please add a comment about why it has been NO-OP'ed away and why the
developer who follows might need it.
Re: svn commit: r1186545 - /httpd/httpd/trunk/server/mpm/simple/simple_io.c
Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 10/25/2011 12:00 PM, Jim Jagielski wrote:
> These types of things exist for a reason. Please don't
> remove them…
Nobody left a comment to explain why it was left dangling,
and it does nothing.
+1 - remove it.
http://badprogrammer.infogami.com/ ... c.f. Collyer Brothers syndrome