[jira] Resolved: (BUILDR-508) Remove unnecessary use of Java.classpath in OpenJPA extension

["Alex Boisvert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BUILDR-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved BUILDR-508.
----------------------------------

    Resolution: Fixed

Thanks Peter.

I removed the "Java.classpath << REQUIRES" as in the patch but retained the VERSION constant to maintain backward compatibility since it seemed just a cosmetic change and I have no idea if anyone's using VERSION.

Sending        CHANGELOG
Sending        addon/buildr/openjpa.rb
Transmitting file data ..
Committed revision 997723.


> Remove unnecessary use of Java.classpath in OpenJPA extension
> -------------------------------------------------------------
>
>                 Key: BUILDR-508
>                 URL: https://issues.apache.org/jira/browse/BUILDR-508
>             Project: Buildr
>          Issue Type: Bug
>            Reporter: Peter Donald
>             Fix For: 1.4.2
>
>         Attachments: OpenJPA_NoClasspath.diff
>
>
> The OpenJPA extension adds a bunch of jars to the classpath. This is not really necessary as the extension uses ant to run task and defines a classpath in ant taskdef. It can also cause issues when you want to change the version of OpenJPA you want to use. Note that I do this by ruby below. The attached patch removes this unnecessary setting of classpath and inlines version.
> Buildr::OpenJPA.send :remove_const, :REQUIRES
> Buildr::OpenJPA.const_set(:REQUIRES, ["org.apache.openjpa:openjpa:jar:2.0.1",
>                                       "commons-collections:commons-collections:jar:3.1",
>                                       "commons-dbcp:commons-dbcp:jar:1.2.1",
>                                       "commons-lang:commons-lang:jar:2.1",
>                                       "commons-pool:commons-pool:jar:1.2",
>                                       "org.hibernate.javax.persistence:hibernate-jpa-2.0-api:jar:1.0.0.Final",
>                                       "org.apache.geronimo.specs:geronimo-j2ee-connector_1.5_spec:jar:1.0",
>                                       "org.apache.geronimo.specs:geronimo-jta_1.0.1B_spec:jar:1.0",
>                                       "org.apache.geronimo.specs:geronimo-jpa_2.0_spec:jar:1.1",
>                                       "org.apache.geronimo.specs:geronimo-validation_1.0_spec:jar:1.1",
>                                       "net.sourceforge.serp:serp:jar:1.13.1"])

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.