You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2010/04/29 00:57:12 UTC
[jira] Closed: (MCHANGELOG-74) Combined patch for MCHANGELOG-69,
MCHANGELOG-70, MCHANGELOG-71, MCHANGELOG-72, MCHANGELOG-73
[ http://jira.codehaus.org/browse/MCHANGELOG-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MCHANGELOG-74.
-------------------------------------
Resolution: Won't Fix
I applied the individual patches instead.
> Combined patch for MCHANGELOG-69, MCHANGELOG-70, MCHANGELOG-71, MCHANGELOG-72, MCHANGELOG-73
> --------------------------------------------------------------------------------------------
>
> Key: MCHANGELOG-74
> URL: http://jira.codehaus.org/browse/MCHANGELOG-74
> Project: Maven 2.x Changelog Plugin
> Issue Type: Task
> Affects Versions: 2.1
> Reporter: John Allen
> Attachments: MCHANGELOG-69,70,71,72,73.patch, MCHANGELOG-69,70,71,72,73.patch, MCHANGELOG-69,70,71,72,73.patch
>
>
> This is a combined patch for MCHANGELOG-69, MCHANGELOG-70, MCHANGELOG-71, MCHANGELOG-72, MCHANGELOG-73. I have produced individual patches for each issue so that the code can easily be reviewed by the committers and then this combined patch to allow all those mini-patches to be easily applied against the trunk.
> I hope this is considered ok as I could not think of a better way to make the job of the committer easy, plus it was right pain to do
> All updates made against trunk revision 560535.
> Note there are two change in this combined patch to the individual patches - due to MCHANGELOG-68 I had switched on ignore test failures - and being an idiot had not kept track of how many unit tests were failing. To my horror I noticed that loads of the tests were failing but not due to functional issues as such but instead due to the NPEs being raised because a lack of injected values. I have since changed the code to, where appropriate, check for nulls and thus all the unit tests NPEs have gone away. Sorry I should have had my eye on this right from the start.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira