You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/05 18:09:27 UTC

[GitHub] [pulsar] Vanlightly commented on pull request #11571: [C++] Fix testConnectTimeout test by shutting down clients

Vanlightly commented on pull request #11571:
URL: https://github.com/apache/pulsar/pull/11571#issuecomment-893674605


   The issue I am addressing is perhaps due to how I am running the tests, via IntelliJ and the main.cc.
   
   I misdiagnosed which mutex was being incorrectly operated on, it is in fact the `promiseDefault`of the test:
   
   https://github.com/apache/pulsar/blob/3bfbee1a8eeeed40c8615351474e69c79906b31e/pulsar-client-cpp/tests/ClientTest.cc#L107
   
   The issue is not about the iterating of the endpoints but that the connection timeout triggers after the test has completed and the promise out of scope. Calling close() on the client doesn't stop the connect timer, so when it triggers it executes `promiseDefault.set_value(result);` which was already destructed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org