You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Udi Meiri (Jira)" <ji...@apache.org> on 2019/10/24 18:22:00 UTC

[jira] [Updated] (BEAM-8473) Python typehints: spurious warnings for Generator None args

     [ https://issues.apache.org/jira/browse/BEAM-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Udi Meiri updated BEAM-8473:
----------------------------
    Status: Open  (was: Triage Needed)

> Python typehints: spurious warnings for Generator None args
> -----------------------------------------------------------
>
>                 Key: BEAM-8473
>                 URL: https://issues.apache.org/jira/browse/BEAM-8473
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Udi Meiri
>            Assignee: Udi Meiri
>            Priority: Major
>
> GeneratorHint outputs warnings if the 2 last args of typing.Generator are not None.
> 1. Compare to type(None) instead of None, since that's what the code converts those to. (assert on logging output)
> 2. Bug: comparing send_type in both cases.
> https://github.com/apache/beam/blob/06fa1cc2a92a6f4f0e05f162ee2eb78b072920d9/sdks/python/apache_beam/typehints/typehints.py#L1088-L1091



--
This message was sent by Atlassian Jira
(v8.3.4#803005)