[jira] [Commented] (ORC-210) Add encoding for Double, Float.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172834#comment-16172834 ] 

ASF GitHub Bot commented on ORC-210:
------------------------------------

Github user sundapeng commented on a diff in the pull request:

    https://github.com/apache/orc/pull/161#discussion_r139888584
  
    --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java ---
    @@ -688,17 +700,23 @@ protected void skipRows(long items) throws IOException {
       }
     
       public static class DoubleTreeReader extends TreeReader {
    -    protected InStream stream;
    -    private final SerializationUtils utils;
    +    private DoubleReader reader;
    --- End diff --
    
    Hi @pudidic , thank you for the patch!
    I found `reader` should be `protected` here for Hive integration. [EncodedTreeReaderFactory](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java#L950)
    And since we would remove a `protected` variable, could we reuse the `stream`?


> Add encoding for Double, Float.
> -------------------------------
>
>                 Key: ORC-210
>                 URL: https://issues.apache.org/jira/browse/ORC-210
>             Project: ORC
>          Issue Type: Improvement
>          Components: encoding, Java
>    Affects Versions: 1.5.0
>            Reporter: Dapeng Sun
>            Assignee: Teddy Choi
>         Attachments: ORC-210.1.patch, ORC-210.2.patch, patch.txt
>
>
> Currently, Double and Float are using PLAIN encoding, it is better to support encoding such as Dictionary or BitPacking to reduce the storage cost.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)