You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/03 06:40:05 UTC

[GitHub] [beam] mosche commented on pull request #22525: Fix deleteTimer in InMemoryTimerInternals and enable VR tests for GroupIntoBatches.

mosche commented on PR #22525:
URL: https://github.com/apache/beam/pull/22525#issuecomment-1203546034

   > Is it expected that they're not running for [Spark](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_PR/479/testReport/org.apache.beam.sdk.transforms/)?
   
   Yes, I had to tag the tests with `UsesOnWindowExpiration` to make sure they are not run for Spark. I'm also making sure the Spark runner fails at translation time if `onWindowExpiration` is used. Otherwise it would silently lead to wrong results...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org