[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #46: fixed wrong context bug during many async spans

[GitBox <gi...@apache.org>]

tom-pytel opened a new pull request #46:
URL: https://github.com/apache/skywalking-nodejs/pull/46


   Found a bug during stress testing with many asynchronous spans with different contexts running concurrently. In that situation some child spans were being assigned wrong parents because of wrong `Context` at head of `asyncState`. Removed this redundant and potentially incorrect field and now just getting the current context from the topmost `Span` on the stack. Also added check for `context` as well as `id` to span add to stack in `SpanContext`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #46: BugFix: wrong context during many async spans

[GitBox <gi...@apache.org>]

kezhenxu94 merged pull request #46:
URL: https://github.com/apache/skywalking-nodejs/pull/46


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org