You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2023/03/14 08:44:59 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request, #19800: [fix][broker] Copy subscription properties during updating the topic partition number.
mattisonchao opened a new pull request, #19800:
URL: https://github.com/apache/pulsar/pull/19800
### Motivation
This PR is cherry-picking original PR #19223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #19800: [fix][broker] Copy subscription properties during updating the topic partition number.
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #19800: [fix][broker] Copy subscription properties during updating the topic partition number.
URL: https://github.com/apache/pulsar/pull/19800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #19800: [improve][broker] Copy subscription properties during updating the topic partition number.
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on PR #19800:
URL: https://github.com/apache/pulsar/pull/19800#issuecomment-1467462119
@mattisonchao I think it should be a bug fix, not an improvement. No one will treat the fixing of the missed subscription's properties as an improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19800: [improve][broker] Copy subscription properties during updating the topic partition number.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19800:
URL: https://github.com/apache/pulsar/pull/19800#issuecomment-1467191894
@mattisonchao Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #19800: [fix][broker] Copy subscription properties during updating the topic partition number.
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #19800: [fix][broker] Copy subscription properties during updating the topic partition number.
URL: https://github.com/apache/pulsar/pull/19800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #19800: [fix][broker] Copy subscription properties during updating the topic partition number.
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #19800:
URL: https://github.com/apache/pulsar/pull/19800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #19800: [fix][broker] Copy subscription properties during updating the topic partition number.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #19800:
URL: https://github.com/apache/pulsar/pull/19800#issuecomment-1467810153
@codelipenghui Let me change the original PR title. Thanks for your reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao closed pull request #19800: [improve][broker] Copy subscription properties during updating the topic partition number.
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19800: [improve][broker] Copy subscription properties during updating the topic partition number.
URL: https://github.com/apache/pulsar/pull/19800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org