You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/06/05 20:29:15 UTC
Re: Review Request 21499: Added healthy field to TaskUpdate.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/
-----------------------------------------------------------
(Updated June 5, 2014, 11:29 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
As a part of the health check story, this patch adds an optional
healthy field to the task update proto. The semanticist should be
understood as, if the field is absent - no health check has (yet) been
carried out. If present, it will either encode unhealthy
(healthy=false) or healthy determined by the HealthCheck protobuf in
the command info proto. This means that multiple TASK_RUNNING updates
can be sent for a task, updating the state of the last health check.
Diffs
-----
include/mesos/mesos.proto 8012873
Diff: https://reviews.apache.org/r/21499/diff/
Testing
-------
Thanks,
Niklas Nielsen
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/#review45120
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On June 9, 2014, 7:53 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21499/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 7:53 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As a part of the health check story, this patch adds an optional
> healthy field to the task update proto. The semanticist should be
> understood as, if the field is absent - no health check has (yet) been
> carried out. If present, it will either encode unhealthy
> (healthy=false) or healthy determined by the HealthCheck protobuf in
> the command info proto. This means that multiple TASK_RUNNING updates
> can be sent for a task, updating the state of the last health check.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 62f69d2
>
> Diff: https://reviews.apache.org/r/21499/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On June 9, 2014, 3:35 p.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 517
> > <https://reviews.apache.org/r/21499/diff/2/?file=605866#file605866line517>
> >
> > Need to use 8.
Whoops - good point. Thanks!
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/#review45160
-----------------------------------------------------------
On June 9, 2014, 6:11 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21499/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 6:11 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As a part of the health check story, this patch adds an optional
> healthy field to the task update proto. The semanticist should be
> understood as, if the field is absent - no health check has (yet) been
> carried out. If present, it will either encode unhealthy
> (healthy=false) or healthy determined by the HealthCheck protobuf in
> the command info proto. This means that multiple TASK_RUNNING updates
> can be sent for a task, updating the state of the last health check.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 62f69d2
>
> Diff: https://reviews.apache.org/r/21499/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/#review45160
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/21499/#comment79853>
Need to use 8.
- Timothy Chen
On June 9, 2014, 7:53 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21499/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 7:53 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As a part of the health check story, this patch adds an optional
> healthy field to the task update proto. The semanticist should be
> understood as, if the field is absent - no health check has (yet) been
> carried out. If present, it will either encode unhealthy
> (healthy=false) or healthy determined by the HealthCheck protobuf in
> the command info proto. This means that multiple TASK_RUNNING updates
> can be sent for a task, updating the state of the last health check.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 62f69d2
>
> Diff: https://reviews.apache.org/r/21499/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/#review45147
-----------------------------------------------------------
Bad patch!
Reviews applied: [21499]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
ar: creating libleveldb.a
mesos.proto:517:27: Field number 7 has already been used in "mesos.TaskStatus" by field "executor_id".
mesos.proto:517:27: Field number 7 has already been used in "mesos.TaskStatus" by field "executor_id".
containerizer/containerizer.proto: Import "mesos.proto" was not found or had errors.
containerizer/containerizer.proto:32:12: "ContainerID" is not defined.
containerizer/containerizer.proto:33:12: "TaskInfo" is not defined.
containerizer/containerizer.proto:34:12: "ExecutorInfo" is not defined.
containerizer/containerizer.proto:37:12: "SlaveID" is not defined.
containerizer/containerizer.proto:48:12: "ContainerID" is not defined.
containerizer/containerizer.proto:49:12: "Resource" is not defined.
containerizer/containerizer.proto:58:12: "ContainerID" is not defined.
containerizer/containerizer.proto:67:12: "ContainerID" is not defined.
containerizer/containerizer.proto:76:12: "ContainerID" is not defined.
containerizer/containerizer.proto:100:12: "ContainerID" is not defined.
make[2]: *** [containerizer/containerizer.pb.cc] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [mesos.pb.cc] Error 1
mesos.proto:517:27: Field number 7 has already been used in "mesos.TaskStatus" by field "executor_id".
scheduler/scheduler.proto: Import "mesos.proto" was not found or had errors.
scheduler/scheduler.proto:48:14: "FrameworkID" is not defined.
scheduler/scheduler.proto:49:14: "MasterInfo" is not defined.
scheduler/scheduler.proto:53:14: "FrameworkID" is not defined.
scheduler/scheduler.proto:54:14: "MasterInfo" is not defined.
scheduler/scheduler.proto:58:14: "Offer" is not defined.
scheduler/scheduler.proto:62:14: "OfferID" is not defined.
scheduler/scheduler.proto:67:14: "TaskStatus" is not defined.
scheduler/scheduler.proto:71:14: "SlaveID" is not defined.
scheduler/scheduler.proto:72:14: "ExecutorID" is not defined.
scheduler/scheduler.proto:77:14: "SlaveID" is not defined.
scheduler/scheduler.proto:82:14: "ExecutorID" is not defined.
scheduler/scheduler.proto:139:14: "mesos.Request" is not defined.
scheduler/scheduler.proto:143:14: "OfferID" is not defined.
scheduler/scheduler.proto:144:14: "Filters" is not defined.
scheduler/scheduler.proto:148:14: "TaskInfo" is not defined.
scheduler/scheduler.proto:149:14: "OfferID" is not defined.
scheduler/scheduler.proto:150:14: "Filters" is not defined.
scheduler/scheduler.proto:154:14: "TaskID" is not defined.
scheduler/scheduler.proto:158:14: "SlaveID" is not defined.
scheduler/scheduler.proto:159:14: "TaskID" is not defined.
scheduler/scheduler.proto:172:14: "TaskStatus" is not defined.
scheduler/scheduler.proto:176:14: "SlaveID" is not defined.
scheduler/scheduler.proto:177:14: "ExecutorID" is not defined.
scheduler/scheduler.proto:184:12: "FrameworkInfo" is not defined.
make[2]: *** [scheduler/scheduler.pb.cc] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On June 9, 2014, 7:53 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21499/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 7:53 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As a part of the health check story, this patch adds an optional
> healthy field to the task update proto. The semanticist should be
> understood as, if the field is absent - no health check has (yet) been
> carried out. If present, it will either encode unhealthy
> (healthy=false) or healthy determined by the HealthCheck protobuf in
> the command info proto. This means that multiple TASK_RUNNING updates
> can be sent for a task, updating the state of the last health check.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 62f69d2
>
> Diff: https://reviews.apache.org/r/21499/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/#review45225
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21499]
All tests passed.
- Mesos ReviewBot
On June 10, 2014, 1:11 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21499/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 1:11 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As a part of the health check story, this patch adds an optional
> healthy field to the task update proto. The semanticist should be
> understood as, if the field is absent - no health check has (yet) been
> carried out. If present, it will either encode unhealthy
> (healthy=false) or healthy determined by the HealthCheck protobuf in
> the command info proto. This means that multiple TASK_RUNNING updates
> can be sent for a task, updating the state of the last health check.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 62f69d2
>
> Diff: https://reviews.apache.org/r/21499/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/#review45287
-----------------------------------------------------------
Ship it!
include/mesos/mesos.proto
<https://reviews.apache.org/r/21499/#comment80048>
As this moves to TaskInfo let's make sure we update the comment.
- Benjamin Hindman
On June 10, 2014, 1:11 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21499/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 1:11 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As a part of the health check story, this patch adds an optional
> healthy field to the task update proto. The semanticist should be
> understood as, if the field is absent - no health check has (yet) been
> carried out. If present, it will either encode unhealthy
> (healthy=false) or healthy determined by the HealthCheck protobuf in
> the command info proto. This means that multiple TASK_RUNNING updates
> can be sent for a task, updating the state of the last health check.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 62f69d2
>
> Diff: https://reviews.apache.org/r/21499/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/
-----------------------------------------------------------
(Updated June 9, 2014, 6:11 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Addressed Tim's comment.
Repository: mesos-git
Description
-------
As a part of the health check story, this patch adds an optional
healthy field to the task update proto. The semanticist should be
understood as, if the field is absent - no health check has (yet) been
carried out. If present, it will either encode unhealthy
(healthy=false) or healthy determined by the HealthCheck protobuf in
the command info proto. This means that multiple TASK_RUNNING updates
can be sent for a task, updating the state of the last health check.
Diffs (updated)
-----
include/mesos/mesos.proto 62f69d2
Diff: https://reviews.apache.org/r/21499/diff/
Testing
-------
Thanks,
Niklas Nielsen
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/
-----------------------------------------------------------
(Updated June 9, 2014, 12:53 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Rebased and ready for review.
Repository: mesos-git
Description
-------
As a part of the health check story, this patch adds an optional
healthy field to the task update proto. The semanticist should be
understood as, if the field is absent - no health check has (yet) been
carried out. If present, it will either encode unhealthy
(healthy=false) or healthy determined by the HealthCheck protobuf in
the command info proto. This means that multiple TASK_RUNNING updates
can be sent for a task, updating the state of the last health check.
Diffs (updated)
-----
include/mesos/mesos.proto 62f69d2
Diff: https://reviews.apache.org/r/21499/diff/
Testing
-------
Thanks,
Niklas Nielsen
Re: Review Request 21499: Added healthy field to TaskUpdate.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21499/#review44967
-----------------------------------------------------------
Bad patch!
Reviews applied: [21499]
Failed command: git apply --index 21499.patch
Error:
error: patch failed: include/mesos/mesos.proto:502
error: include/mesos/mesos.proto: patch does not apply
- Mesos ReviewBot
On June 5, 2014, 6:29 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21499/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 6:29 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As a part of the health check story, this patch adds an optional
> healthy field to the task update proto. The semanticist should be
> understood as, if the field is absent - no health check has (yet) been
> carried out. If present, it will either encode unhealthy
> (healthy=false) or healthy determined by the HealthCheck protobuf in
> the command info proto. This means that multiple TASK_RUNNING updates
> can be sent for a task, updating the state of the last health check.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8012873
>
> Diff: https://reviews.apache.org/r/21499/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>