You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/10 22:39:01 UTC
[jira] [Commented] (FLUME-953) Enable ability to pass arguments to
the FlumeNodeDaemon through Windows Service
[ https://issues.apache.org/jira/browse/FLUME-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205780#comment-13205780 ]
jiraposter@reviews.apache.org commented on FLUME-953:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3842/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Allows you to specify arguments which you pass into the windows flume agent. Before this change, we would always pass in a New String[].
This addresses bug FLUME-953.
https://issues.apache.org/jira/browse/FLUME-953
Diffs
-----
/trunk/flume-core/src/main/java/com/cloudera/flume/agent/FlumeNodeDaemon.java 1242873
Diff: https://reviews.apache.org/r/3842/diff
Testing
-------
I could not find any tests around the FlumeNodeDaemon, which made me think there were probably reasons why it was not under test. I did however, run the daemon with the arguments "start", and then "start -s," and confirmed they both had expected behavior. This is a trivial change which only affects windows flume nodes, so I do not think this will be an issue.
Thanks,
trega
> Enable ability to pass arguments to the FlumeNodeDaemon through Windows Service
> -------------------------------------------------------------------------------
>
> Key: FLUME-953
> URL: https://issues.apache.org/jira/browse/FLUME-953
> Project: Flume
> Issue Type: New Feature
> Components: Windows
> Affects Versions: v0.9.5, v1.1.0
> Environment: Windows
> Reporter: Thomas Rega
> Priority: Minor
> Labels: WAP, arguments, daemon, flume, jetty, service, windows
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Currently, we are unable to pass in agruments to the FlumeNodeDaemon.WindowsService method other than Start and Stop. Particularly a useful command would be to start, but with the jetty wap disabled. Really, we should be able to specify any arguments (such as -s), by placing them after Start. For example, Start -s.
> I have already written this change locally and would like suggestions before I submit it for review. Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira