You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2023/01/06 11:30:03 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
zuston opened a new pull request, #458:
URL: https://github.com/apache/incubator-uniffle/pull/458
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Record every partition data size for one app
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This is a subtask for #378
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
1. UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063381378
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html#computeIfPresent-K-java.util.function.BiFunction-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#issuecomment-1373588801
> Could you modify the title? What's `n`?
n means several subtasks. In the next PR, it will named as 2/n.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #458: [ISSUE-378][HugePartition][Part-1] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#issuecomment-1373753811
Thanks @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#issuecomment-1373594525
> > > Could you modify the title? What's `n`?
>
> >
>
> > n means several subtasks. In the next PR, it will named as 2/n.
>
>
>
> So n is 3 or 4? If we can't ensure what n is. Could we use `[Part-1]` directly?
Yes. It' OK for me. Could you help modify the title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063371132
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
What will it happen if two threads add the same partition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063366121
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
AtomicLong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063385376
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
OK, my mistake. I just see the default method of `Map`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063372367
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
This will guarded by `computeIfPresent` to keep thread safe when having multiple threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063368084
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
It will be added by the `ConcurrentHashMap.computeIfPresent,` this is a thread safe operation. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #458: [ISSUE-378][HugePartition][Part-1] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#issuecomment-1373595808
> > > > Could you modify the title? What's `n`?
> >
> >
> > >
> >
> >
> > > n means several subtasks. In the next PR, it will named as 2/n.
> >
> >
> > So n is 3 or 4? If we can't ensure what n is. Could we use `[Part-1]` directly?
>
> Yes. It' OK for me. Could you help modify the title?
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#issuecomment-1373589908
> > Could you modify the title? What's `n`?
>
> n means several subtasks. In the next PR, it will named as 2/n.
So n is 3 or 4? If we can't ensure what n is. Could we use `[Part-1]` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#issuecomment-1373535261
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#458](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f4d52b) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/2b756c3477d5adbbd60c3929ac7878afa4afcb97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b756c3) will **decrease** coverage by `0.60%`.
> The diff coverage is `86.95%`.
```diff
@@ Coverage Diff @@
## master #458 +/- ##
============================================
- Coverage 58.67% 58.07% -0.61%
+ Complexity 1655 1444 -211
============================================
Files 199 177 -22
Lines 11214 9399 -1815
Branches 997 839 -158
============================================
- Hits 6580 5458 -1122
+ Misses 4242 3592 -650
+ Partials 392 349 -43
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/uniffle/server/ShuffleServerGrpcService.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyR3JwY1NlcnZpY2UuamF2YQ==) | `0.80% <0.00%> (ø)` | |
| [...ava/org/apache/uniffle/server/ShuffleTaskInfo.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlVGFza0luZm8uamF2YQ==) | `94.44% <87.50%> (-5.56%)` | :arrow_down: |
| [.../org/apache/uniffle/server/ShuffleTaskManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlVGFza01hbmFnZXIuamF2YQ==) | `76.34% <100.00%> (+0.45%)` | :arrow_up: |
| [...storage/handler/impl/DataSkippableReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9EYXRhU2tpcHBhYmxlUmVhZEhhbmRsZXIuamF2YQ==) | `83.78% <0.00%> (-2.71%)` | :arrow_down: |
| [...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL01SSWRIZWxwZXIuamF2YQ==) | | |
| [...g/apache/hadoop/mapred/SortWriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkL1NvcnRXcml0ZUJ1ZmZlck1hbmFnZXIuamF2YQ==) | | |
| [...k/shuffle/writer/WrappedByteArrayOutputStream.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JhcHBlZEJ5dGVBcnJheU91dHB1dFN0cmVhbS5qYXZh) | | |
| [...pache/spark/shuffle/writer/WriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVCdWZmZXJNYW5hZ2VyLmphdmE=) | | |
| [...e/spark/shuffle/reader/RssShuffleDataIterator.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9yZWFkZXIvUnNzU2h1ZmZsZURhdGFJdGVyYXRvci5qYXZh) | | |
| [.../hadoop/mapreduce/task/reduce/RssBypassWriter.java](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0J5cGFzc1dyaXRlci5qYXZh) | | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-uniffle/pull/458?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston merged pull request #458: [ISSUE-378][HugePartition][Part-1] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston merged PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#issuecomment-1373555479
Could you modify the title? What's `n`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063381378
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
I think this is thread safe , https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html#computeIfPresent-K-java.util.function.BiFunction-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063373551
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
private AtomicReference<ShuffleDataDistributionType> dataDistType;
+ private AtomicLong totalDataSize = new AtomicLong(0);
+ /**
+ * shuffleId -> partitionId -> partition shuffle data size
+ */
+ private Map<Integer, Map<Integer, Long>> partitionDataSizes;
Review Comment:
You can see the code of `computeIfpresent`. `computeIfpresent` don't guard the atomicity. Only the one partition will be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org