You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/22 09:08:03 UTC

[GitHub] [kafka] ccding commented on a change in pull request #11426: KAFKA-13391: don't fsync directory on Windows OS

ccding commented on a change in pull request #11426:
URL: https://github.com/apache/kafka/pull/11426#discussion_r734367737



##########
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##########
@@ -948,10 +948,12 @@ public static void atomicMoveWithFallback(Path source, Path target, boolean need
     /**
      * Flushes dirty directories to guarantee crash consistency.
      *
+     * Note: We don't fsync directory on Windows OS because it'll throw AccessDeniedException (KAFKA-13391)

Review comment:
       nit: directory -> directories




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org