You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2009/08/17 20:40:14 UTC
[jira] Created: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
-------------------------------------------------------------------------------------------
Key: ZOOKEEPER-508
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
Project: Zookeeper
Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Blocker
Fix For: 3.2.1, 3.3.0
The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-508:
------------------------------------
Attachment: ZOOKEEPER-508.patch
attached missing header to the file.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-508) proposals and commits for DIFF
and Truncate messages from the leader to followers is buggy.
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747155#action_12747155 ]
Benjamin Reed commented on ZOOKEEPER-508:
-----------------------------------------
+1 looks good. simple fix! :)
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch-3.2
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-508:
------------------------------------
Status: Patch Available (was: Open)
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-508:
------------------------------------
Attachment: ZOOKEEPER-508.patch
this fixes the issue so that we sent the right packets when a follower syncs with the leader. also includes ZOOKEEPER-483.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-508:
------------------------------------
Component/s: quorum
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-508) proposals and commits for DIFF
and Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745733#action_12745733 ]
Mahadev konar commented on ZOOKEEPER-508:
-----------------------------------------
I have a patch for the 3.2 branch, will upload is as soon as hudson is done running this patch.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-508:
------------------------------------
Resolution: Fixed
Release Note: includes the fix for ZOOKEEPER-483, ZOOKEEPER-509.
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch-3.2
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-508) proposals and commits for DIFF
and Truncate messages from the leader to followers is buggy.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745755#action_12745755 ]
Hadoop QA commented on ZOOKEEPER-508:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12417189/ZOOKEEPER-508.patch
against trunk revision 803300.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 178 release audit warnings (more than the trunk's current 177 warnings).
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/188/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/188/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/188/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/188/console
This message is automatically generated.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-508:
------------------------------------
Attachment: ZOOKEEPER-508.patch
this patch includes fix for ZOOKEEPER-508, ZOOKEEPER-509, ZOOKEEPER-483. It also includes the test cases for each of them.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-508) proposals and commits for DIFF and
Truncate messages from the leader to followers is buggy.
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-508:
------------------------------------
Attachment: ZOOKEEPER-508.patch
added a testcase for the DIFF problem. still not fixed.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-508) proposals and commits for DIFF
and Truncate messages from the leader to followers is buggy.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747366#action_12747366 ]
Hudson commented on ZOOKEEPER-508:
----------------------------------
Integrated in ZooKeeper-trunk #426 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/426/])
. proposals and commits for DIFF and Truncate messages from the leader to the followers is buggy. (mahadev and ben via mahadev)
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch, ZOOKEEPER-508.patch-3.2
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-508) proposals and commits for DIFF
and Truncate messages from the leader to followers is buggy.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745683#action_12745683 ]
Mahadev konar commented on ZOOKEEPER-508:
-----------------------------------------
i fugured out the reason why it fails on the assertion errors != 0. The whole scenario of 483 fialing with truncate is this
- the test case shutdowns all the followers
- the leader does not realize that its lost the leadership, becasue the time we ping to see if the leader is still the leader (maybe 1 sec) is greater than the time hte followers actually take to shutdown and get back and in sync with the leader
- so the leader never shutsdown any of its stuff (no NIO rejection or nething else)
so in your case, sometimes the client conencts to the leader and will never see errors. On the other hand sometimes it may pas s on connection to other followers and your testcase will pass. So we cannot really say that your test case is fool proof.
> proposals and commits for DIFF and Truncate messages from the leader to followers is buggy.
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-508
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-508.patch, ZOOKEEPER-508.patch
>
>
> The proposals and commits sent by the leader after it asks the followers to truncate there logs or starts sending a diff has missing messages which causes out of order commits messages and causes the followers to shutdown because of these out of order commits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.