You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/10 10:20:16 UTC
[GitHub] [flink] zentol opened a new pull request #16131: [FLINK-22952][azure] Use Ruby 2.5.9
zentol opened a new pull request #16131:
URL: https://github.com/apache/flink/pull/16131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16131: [1.12][FLINK-22952][azure] Use Ruby 2.5.9
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16131:
URL: https://github.com/apache/flink/pull/16131#issuecomment-858523101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8fb245a23a4bb6311791555c8163520f7c6bff33",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18872",
"triggerID" : "8fb245a23a4bb6311791555c8163520f7c6bff33",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8fb245a23a4bb6311791555c8163520f7c6bff33 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18872)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #16131: [1.12][FLINK-22952][azure] Use Ruby 2.5.9
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #16131:
URL: https://github.com/apache/flink/pull/16131#discussion_r649213429
##########
File path: tools/azure-pipelines/build-apache-repo.yml
##########
@@ -140,7 +140,7 @@ stages:
steps:
- task: UseRubyVersion@0
inputs:
- versionSpec: '= 2.4'
+ versionSpec: '= 2.5.9'
Review comment:
Did you intentionally set 2.5.9 instead of `2.5`?
```
##[warning]It is not recommended to specify exact version on Microsoft-Hosted agents. Patch version of Ruby can be replaced by new one on Hosted agents without notice and build stops to work. it is recommended to specify only major or major and minor version (Example: `2` or `2.4`)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16131: [1.12][FLINK-22952][azure] Use Ruby 2.5.9
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16131:
URL: https://github.com/apache/flink/pull/16131#discussion_r649254985
##########
File path: tools/azure-pipelines/build-apache-repo.yml
##########
@@ -140,7 +140,7 @@ stages:
steps:
- task: UseRubyVersion@0
inputs:
- versionSpec: '= 2.4'
+ versionSpec: '= 2.5.9'
Review comment:
I only picked 2.5.9 because that is what was listed in the error message; if the patch version isn't required than I'm fine with removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16131: [1.12][FLINK-22952][azure] Use Ruby 2.5.9
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16131:
URL: https://github.com/apache/flink/pull/16131#issuecomment-858503070
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8fb245a23a4bb6311791555c8163520f7c6bff33 (Thu Jun 10 10:22:07 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #16131: [1.12][FLINK-22952][azure] Use Ruby 2.5.9
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16131:
URL: https://github.com/apache/flink/pull/16131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16131: [1.12][FLINK-22952][azure] Use Ruby 2.5.9
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16131:
URL: https://github.com/apache/flink/pull/16131#issuecomment-858503070
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 801ada343d2c36592dfe6285c96c4ee5b9f9f783 (Sat Aug 28 12:15:40 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16131: [1.12][FLINK-22952][azure] Use Ruby 2.5.9
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16131:
URL: https://github.com/apache/flink/pull/16131#issuecomment-858523101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8fb245a23a4bb6311791555c8163520f7c6bff33",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8fb245a23a4bb6311791555c8163520f7c6bff33",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8fb245a23a4bb6311791555c8163520f7c6bff33 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org