You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/22 21:49:54 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #9888: feat: make CRUD annotations inline
mistercrunch opened a new pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888
# Summary
This makes the annotations inline of the "annotation layers". Originally
they were setup as separate ModelViews because of a bug in FAB.
## Before
<img width="761" alt="Screen Shot 2020-05-22 at 2 47 44 PM" src="https://user-images.githubusercontent.com/487433/82711783-43a34b00-9c3b-11ea-94cb-12e1ffd290e9.png">
## After
<img width="285" alt="Screen Shot 2020-05-22 at 2 23 43 PM" src="https://user-images.githubusercontent.com/487433/82711794-4a31c280-9c3b-11ea-8573-6f915e67f5a8.png">
<img width="1203" alt="Screen Shot 2020-05-22 at 2 23 19 PM" src="https://user-images.githubusercontent.com/487433/82711817-59187500-9c3b-11ea-9203-40ea8370e31c.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 70.89% -0.36%
==========================================
Files 584 184 -400
Lines 30789 17891 -12898
Branches 3238 0 -3238
==========================================
- Hits 21937 12683 -9254
+ Misses 8742 5208 -3534
+ Partials 110 0 -110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.89% <100.00%> (+6.58%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| ... and [436 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...eaeb12b](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `4.83%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 66.41% -4.84%
==========================================
Files 584 584
Lines 30789 30791 +2
Branches 3238 3238
==========================================
- Hits 21937 20451 -1486
- Misses 8742 10153 +1411
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.32% <100.00%> (+7.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <100.00%> (ø)` | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [143 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `4.85%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 66.39% -4.86%
==========================================
Files 584 584
Lines 30789 30791 +2
Branches 3238 3238
==========================================
- Hits 21937 20444 -1493
- Misses 8742 10160 +1418
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.29% <100.00%> (+6.98%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <100.00%> (ø)` | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [147 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 71.20% -0.05%
==========================================
Files 584 584
Lines 30789 30791 +2
Branches 3238 3238
==========================================
- Hits 21937 21926 -11
- Misses 8742 8755 +13
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.83% <ø> (-10.75%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.32% <100.00%> (+7.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <100.00%> (ø)` | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.51% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.84% <0.00%> (-0.22%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 71.10% -0.15%
==========================================
Files 584 584
Lines 30789 30608 -181
Branches 3238 3238
==========================================
- Hits 21937 21764 -173
+ Misses 8742 8734 -8
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.84% <ø> (-10.73%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.14% <100.00%> (+6.84%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <0.00%> (-3.14%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `67.74% <0.00%> (-1.96%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.16% <0.00%> (-0.90%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 70.89% -0.36%
==========================================
Files 584 584
Lines 30789 30608 -181
Branches 3238 3238
==========================================
- Hits 21937 21699 -238
- Misses 8742 8792 +50
- Partials 110 117 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.99% <ø> (-11.59%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.14% <100.00%> (+6.84%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [35 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `11.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
===========================================
- Coverage 71.24% 59.44% -11.81%
===========================================
Files 584 400 -184
Lines 30789 12717 -18072
Branches 3238 3238
===========================================
- Hits 21937 7559 -14378
+ Misses 8742 4971 -3771
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [320 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `5.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 66.24% -5.01%
==========================================
Files 584 584
Lines 30789 30608 -181
Branches 3238 3238
==========================================
- Hits 21937 20276 -1661
- Misses 8742 10145 +1403
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.08% <100.00%> (+6.77%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.50%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 70.74% -0.51%
==========================================
Files 584 584
Lines 30789 30608 -181
Branches 3238 3238
==========================================
- Hits 21937 21653 -284
- Misses 8742 8838 +96
- Partials 110 117 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.99% <ø> (-11.59%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `70.89% <100.00%> (+6.58%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...eaeb12b](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 71.24% -0.01%
==========================================
Files 584 584
Lines 30789 30791 +2
Branches 3238 3238
==========================================
+ Hits 21937 21938 +1
- Misses 8742 8743 +1
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.83% <ø> (-10.75%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.39% <100.00%> (+7.08%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <100.00%> (ø)` | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.51% <0.00%> (-1.13%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `5.11%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 66.13% -5.12%
==========================================
Files 584 584
Lines 30789 30608 -181
Branches 3238 3238
==========================================
- Hits 21937 20242 -1695
- Misses 8742 10179 +1437
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `70.89% <100.00%> (+6.58%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...eaeb12b](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `5.11%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 66.13% -5.12%
==========================================
Files 584 584
Lines 30789 30608 -181
Branches 3238 3238
==========================================
- Hits 21937 20242 -1695
- Misses 8742 10179 +1437
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `70.89% <100.00%> (+6.58%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#discussion_r433780284
##########
File path: superset/views/annotations.py
##########
@@ -14,14 +14,15 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from flask_appbuilder import CompactCRUDMixin
from flask_appbuilder.models.sqla.interface import SQLAInterface
from flask_babel import lazy_gettext as _
from wtforms.validators import StopValidation
from superset.constants import RouteMethod
from superset.models.annotations import Annotation, AnnotationLayer
-from .base import DeleteMixin, SupersetModelView
+from .base import SupersetModelView
Review comment:
nit: We are dumping relative imports
``` python
from superset.views.base import SupersetModelview
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 70.99% -0.26%
==========================================
Files 584 584
Lines 30789 30791 +2
Branches 3238 3238
==========================================
- Hits 21937 21861 -76
- Misses 8742 8813 +71
- Partials 110 117 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.97% <ø> (-11.60%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.32% <100.00%> (+7.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <100.00%> (ø)` | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9888: feat: make CRUD annotations inline
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9888:
URL: https://github.com/apache/incubator-superset/pull/9888#issuecomment-632923786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=h1) Report
> Merging [#9888](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6d4e23663e95659a4f53cbff6d65770ebff562ce&el=desc) will **decrease** coverage by `0.39%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9888 +/- ##
==========================================
- Coverage 71.24% 70.85% -0.40%
==========================================
Files 584 584
Lines 30789 30608 -181
Branches 3238 3238
==========================================
- Hits 21937 21687 -250
- Misses 8742 8804 +62
- Partials 110 117 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.99% <ø> (-11.59%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.08% <100.00%> (+6.77%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.27% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `80.00% <100.00%> (+0.93%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/incubator-superset/pull/9888/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=footer). Last update [6d4e236...6b68bf1](https://codecov.io/gh/apache/incubator-superset/pull/9888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org