You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/28 11:53:55 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #1308: [DOC] Update release docs
pan3793 opened a new pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
We need to update docs in release finalize phase
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#issuecomment-953790116
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1308?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1308](https://codecov.io/gh/apache/incubator-kyuubi/pull/1308?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0e2264) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b97512a805edf6097ae1113fad982ccc6abc7994?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b97512a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head d0e2264 differs from pull request most recent head a79333d. Consider uploading reports for the commit a79333d to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1308 +/- ##
=========================================
Coverage 77.76% 77.76%
Complexity 110 110
=========================================
Files 178 178
Lines 7215 7215
Branches 880 880
=========================================
Hits 5611 5611
Misses 1119 1119
Partials 485 485
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1308?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1308?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b97512a...a79333d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1308?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#discussion_r738314557
##########
File path: docs/community/release.md
##########
@@ -221,6 +221,8 @@ Fork and clone [Apache Kyuubi website](https://github.com/apache/incubator-kyuub
1. Add a new markdown file in `src/news/`
2. Add a new markdown file in `src/release/`
+3. Follow [Build Document](../develop_tools/build_document.md) to build docs, and copy folder `docs/_build/html` to
+ `content/docs/r{RELEASE_VERSION}`
Review comment:
shall we mention the repo name？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#discussion_r738315070
##########
File path: docs/community/release.md
##########
@@ -221,6 +221,8 @@ Fork and clone [Apache Kyuubi website](https://github.com/apache/incubator-kyuub
1. Add a new markdown file in `src/news/`
2. Add a new markdown file in `src/release/`
+3. Follow [Build Document](../develop_tools/build_document.md) to build docs, and copy folder `docs/_build/html` to
+ `content/docs/r{RELEASE_VERSION}`
Review comment:
> why r ？
cc @turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#issuecomment-957257472
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#discussion_r739627390
##########
File path: docs/community/release.md
##########
@@ -221,6 +221,8 @@ Fork and clone [Apache Kyuubi website](https://github.com/apache/incubator-kyuub
1. Add a new markdown file in `src/news/`
2. Add a new markdown file in `src/release/`
+3. Follow [Build Document](../develop_tools/build_document.md) to build docs, and copy folder `docs/_build/html` to
+ `content/docs/r{RELEASE_VERSION}`
Review comment:
It is just a rule, r means `release`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#issuecomment-957257472
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#discussion_r738314096
##########
File path: docs/community/release.md
##########
@@ -221,6 +221,8 @@ Fork and clone [Apache Kyuubi website](https://github.com/apache/incubator-kyuub
1. Add a new markdown file in `src/news/`
2. Add a new markdown file in `src/release/`
+3. Follow [Build Document](../develop_tools/build_document.md) to build docs, and copy folder `docs/_build/html` to
+ `content/docs/r{RELEASE_VERSION}`
Review comment:
why r ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1308: [DOC] Update release docs
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1308:
URL: https://github.com/apache/incubator-kyuubi/pull/1308#issuecomment-957257472
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org