You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jon Meredith (JIRA)" <ji...@apache.org> on 2019/08/16 03:24:00 UTC
[jira] [Comment Edited] (CASSANDRA-15170) Reduce the time needed to
release in-JVM dtest cluster resources after close
[ https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908274#comment-16908274 ]
Jon Meredith edited comment on CASSANDRA-15170 at 8/16/19 3:23 AM:
-------------------------------------------------------------------
Apologies, messed up the 3.11 [CircleCI link|https://circleci.com/workflow-run/aecdc4ac-c267-435e-8d2e-4f238e02d9be]
was (Author: jmeredithco):
Alright, squashed it all down to a commit against 2.2 and merge commits up through against the current origin. There's a CircleCI commit tacked on the end of each which needs to be dropped before merge.
2.2 | [Branch|https://github.com/jonmeredith/cassandra/commits/CASSANDRA-15170-2.2] | [CircleCI|https://circleci.com/workflow-run/db122979-d47a-4d3a-a0e5-0cedef411a46]
3.0 | [Branch|https://github.com/jonmeredith/cassandra/commits/CASSANDRA-15170-3.0] | [CircleCI|https://circleci.com/workflow-run/370d6e4c-6ae8-4167-967a-a88e7b906582]
3.11 | [Branch|https://github.com/jonmeredith/cassandra/commits/CASSANDRA-15170-3.11] | [CircleCI|https://circleci.com/workflow-run/370d6e4c-6ae8-4167-967a-a88e7b906582]
trunk | [Branch|https://github.com/jonmeredith/cassandra/commits/CASSANDRA-15170-trunk] | [CircleCI J8|https://circleci.com/workflow-run/eb1ad032-7b76-4aa2-a975-4ba6496bb74f] | [CircleCI J11|https://circleci.com/workflow-run/c8da2408-6caa-474c-894b-e41c029e2139]
Thanks for all the effort reviewing/rereviewing.
> Reduce the time needed to release in-JVM dtest cluster resources after close
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-15170
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15170
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
>
> There are a few issues that slow the in-JVM dtests from reclaiming metaspace once the cluster is closed.
> IsolatedExecutor issues the shutdown on a SingleExecutorThreadPool, sometimes this thread was still running 10s after the dtest cluster was closed. Instead, switch to a ThreadPoolExecutor with a core pool size of 0 so that the thread executing the class loader close executes sooner.
> If an OutboundTcpConnection is waiting to connect() and the endpoint is not answering, it has to wait for a timeout before it exits. Instead it should check the isShutdown flag and terminate early if shutdown has been requested.
> In 3.0 and above, HintsCatalog.load uses java.nio.Files.list outside of a try-with-resources construct and leaks a file handle for the directory. This doesn't matter for normal usage, it leaks a file handle for each dtest Instance created.
> On trunk, Netty global event executor threads are still running and delay GC for the instance class loader.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org