You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/11 13:31:35 UTC
[GitHub] [incubator-nuttx] davids5 commented on pull request #2273: stm32/stm32_spi: Add SPI register definitions for STM32G47xxx
davids5 commented on pull request #2273:
URL: https://github.com/apache/incubator-nuttx/pull/2273#issuecomment-725424363
> putting this one in chip.h would be a departure from how it is already being done
for all other peripherals.
Just like removing all the ifdef rash, departures form incorrect are a good thing. Putting invariant in Kconfig is not a proper use for it. The Chip file describes the number and version of IP. It is invariant. The IP on a chip does not change.
It makes sense for the Device subfamily, Flash memory size, and Package etc.
It does not make sense for the IP on the die.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org