You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Boris Shkolnik <bo...@apache.org> on 2016/09/21 20:36:55 UTC

Review Request 52133: reopen a Kafka system producer if send called again

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52133/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

reopen a Kafka system producer if send called again


Diffs
-----

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a 

Diff: https://reviews.apache.org/r/52133/diff/


Testing
-------

manual.


Thanks,

Boris Shkolnik


Re: Review Request 52133: reopen a Kafka system producer if send called again

Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52133/#review149925
-----------------------------------------------------------


Ship it!




Ship It!

- Xinyu Liu


On Sept. 21, 2016, 8:36 p.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52133/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 8:36 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> reopen a Kafka system producer if send called again
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a 
> 
> Diff: https://reviews.apache.org/r/52133/diff/
> 
> 
> Testing
> -------
> 
> manual.
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>


Re: Review Request 52133: reopen a Kafka system producer if send called again

Posted by Boris Shkolnik <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52133/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 12:56 a.m.)


Review request for samza.


Changes
-------

added comment.


Repository: samza


Description
-------

reopen a Kafka system producer if send called again


Diffs (updated)
-----

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a 

Diff: https://reviews.apache.org/r/52133/diff/


Testing
-------

manual.


Thanks,

Boris Shkolnik