You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Jeremias Maerki <de...@jeremias-maerki.ch> on 2008/02/22 15:24:19 UTC

Re: svn commit: r630215 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java

Sorry, Max, but it's not that simple. The GNU or Oracle XML parser will
throw a SAXNotRecognizedException here.

On 22.02.2008 15:17:20 maxberger wrote:
> Author: maxberger
> Date: Fri Feb 22 06:17:20 2008
> New Revision: 630215
> 
> URL: http://svn.apache.org/viewvc?rev=630215&view=rev
> Log:
> Fixed backward compatiblity with 1.4
> 
> Modified:
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
> 
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java?rev=630215&r1=630214&r2=630215&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java Fri Feb 22 06:17:20 2008
> @@ -151,8 +151,8 @@
>              InputSource is = new InputSource(new FileInputStream(
>                      this.sourcefile));
>              SAXParserFactory spf = SAXParserFactory.newInstance();
> -            spf.setNamespaceAware(true);
> -            spf.setXIncludeAware(true);
> +            spf.setFeature("http://xml.org/sax/features/namespaces", true);
> +            spf.setFeature("http://apache.org/xml/features/xinclude", true);
>              XMLReader xr = spf.newSAXParser().getXMLReader();
>              result = new SAXSource(xr, is);
>          } catch (SAXException e) {
> 
> 



Jeremias Maerki


Re: svn commit: r630215 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java

Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Oh, right. That's for just looking at the diff. Sorry.

On 22.02.2008 15:29:51 Max Berger wrote:
> Jeremias,
> 
> which is taken care of, as this is a subclass of "SAXException". In this
> case the old behavior will be triggered. 
> 
> ..
>    } catch (SAXException e) {
>             result = new StreamSource(this.sourcefile);
>         } catch (IOException e) {
> ..        
> 
> Max
> 
> On Fre, 2008-02-22 at 15:24 +0100, Jeremias Maerki wrote:
> > Sorry, Max, but it's not that simple. The GNU or Oracle XML parser will
> > throw a SAXNotRecognizedException here.
> > 
> > On 22.02.2008 15:17:20 maxberger wrote:
> > > Author: maxberger
> > > Date: Fri Feb 22 06:17:20 2008
> > > New Revision: 630215
> > > 
> > > URL: http://svn.apache.org/viewvc?rev=630215&view=rev
> > > Log:
> > > Fixed backward compatiblity with 1.4
> > > 
> > > Modified:
> > >     xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
> > > 
> > > Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
> > > URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java?rev=630215&r1=630214&r2=630215&view=diff
> > > ==============================================================================
> > > --- xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java (original)
> > > +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java Fri Feb 22 06:17:20 2008
> > > @@ -151,8 +151,8 @@
> > >              InputSource is = new InputSource(new FileInputStream(
> > >                      this.sourcefile));
> > >              SAXParserFactory spf = SAXParserFactory.newInstance();
> > > -            spf.setNamespaceAware(true);
> > > -            spf.setXIncludeAware(true);
> > > +            spf.setFeature("http://xml.org/sax/features/namespaces", true);
> > > +            spf.setFeature("http://apache.org/xml/features/xinclude", true);
> > >              XMLReader xr = spf.newSAXParser().getXMLReader();
> > >              result = new SAXSource(xr, is);
> > >          } catch (SAXException e) {
> > > 
> > > 
> > 
> > 
> > 
> > Jeremias Maerki
> > 
> mfG
> 
> Max Berger
> e-mail: max@berger.name
> 
> -- 
> OpenPG ID: E81592BC   Print: F489F8759D4132923EC4 BC7E072AB73AE81592BC
> For information about me and my work please see http://max.berger.name
> 




Jeremias Maerki


Re: svn commit: r630215 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java

Posted by Max Berger <ma...@berger.name>.
Jeremias,

which is taken care of, as this is a subclass of "SAXException". In this
case the old behavior will be triggered. 

...
   } catch (SAXException e) {
            result = new StreamSource(this.sourcefile);
        } catch (IOException e) {
...        

Max

On Fre, 2008-02-22 at 15:24 +0100, Jeremias Maerki wrote:
> Sorry, Max, but it's not that simple. The GNU or Oracle XML parser will
> throw a SAXNotRecognizedException here.
> 
> On 22.02.2008 15:17:20 maxberger wrote:
> > Author: maxberger
> > Date: Fri Feb 22 06:17:20 2008
> > New Revision: 630215
> > 
> > URL: http://svn.apache.org/viewvc?rev=630215&view=rev
> > Log:
> > Fixed backward compatiblity with 1.4
> > 
> > Modified:
> >     xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
> > 
> > Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java
> > URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java?rev=630215&r1=630214&r2=630215&view=diff
> > ==============================================================================
> > --- xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java (original)
> > +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java Fri Feb 22 06:17:20 2008
> > @@ -151,8 +151,8 @@
> >              InputSource is = new InputSource(new FileInputStream(
> >                      this.sourcefile));
> >              SAXParserFactory spf = SAXParserFactory.newInstance();
> > -            spf.setNamespaceAware(true);
> > -            spf.setXIncludeAware(true);
> > +            spf.setFeature("http://xml.org/sax/features/namespaces", true);
> > +            spf.setFeature("http://apache.org/xml/features/xinclude", true);
> >              XMLReader xr = spf.newSAXParser().getXMLReader();
> >              result = new SAXSource(xr, is);
> >          } catch (SAXException e) {
> > 
> > 
> 
> 
> 
> Jeremias Maerki
> 
mfG

Max Berger
e-mail: max@berger.name

-- 
OpenPG ID: E81592BC   Print: F489F8759D4132923EC4 BC7E072AB73AE81592BC
For information about me and my work please see http://max.berger.name