You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2009/10/15 05:34:31 UTC

[jira] Created: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Fix CombineFileInputFormat for hadoop 0.20
------------------------------------------

                 Key: MAPREDUCE-1112
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
             Project: Hadoop Map/Reduce
          Issue Type: Bug
    Affects Versions: 0.20.1
            Reporter: Zheng Shao
            Assignee: Zheng Shao
             Fix For: 0.20.2


MAPREDUCE-364 already fixed it in hadoop 0.21. 
This will fix the same problem with CombineFileInputFormat for hadoop 0.20.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Attachment: MAPREDUCE-364.0.20.patch

Ported part of MAPREDUCE-364 to Hadoop 0.20.

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-364.0.20.patch
>
>
> MAPREDUCE-364 already fixed it in hadoop 0.21. 
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Status: Patch Available  (was: Open)

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766999#action_12766999 ] 

Zheng Shao commented on MAPREDUCE-1112:
---------------------------------------

BTW, just to speed up the review, this patch is a subset of changes in MAPREDUCE-364, which is already committed to trunk.


> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767000#action_12767000 ] 

Todd Lipcon commented on MAPREDUCE-1112:
----------------------------------------

Hi Zheng. This looks like the same patch as in HADOOP-5759 (not sure how MAPREDUCE-364 plays in here). So is this JIRA really just that we should apply the HADOOP-5759 patch to branch-20?

Is there a unit test which can verify this by actually running a job using CombineFileInputFormat?

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Resolution: Duplicate
        Status: Resolved  (was: Patch Available)

Duplicate of HADOOP-5759.

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Attachment: MAPREDUCE-1112.2.patch

MAPREDUCE-1112.2.patch: This patch only contains what is needed for CombineFileInputFormat to work with hadoop 0.20.


> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Attachment: MAPREDUCE-1112.1.patch

Removed unnecessary changes to examples.


> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766997#action_12766997 ] 

Zheng Shao commented on MAPREDUCE-1112:
---------------------------------------

Hadoop QA is trying to apply it to trunk... But this is for branch 0.20.

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766991#action_12766991 ] 

Hadoop QA commented on MAPREDUCE-1112:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12422469/MAPREDUCE-1112.2.patch
  against trunk revision 825469.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/179/console

This message is automatically generated.

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Description: 
HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
This will fix the same problem with CombineFileInputFormat for hadoop 0.20.


  was:
MAPREDUCE-364 already fixed it in hadoop 0.21. 
This will fix the same problem with CombineFileInputFormat for hadoop 0.20.



> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-364.0.20.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Attachment:     (was: MAPREDUCE-1112.2.patch)

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Attachment:     (was: MAPREDUCE-364.0.20.patch)

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated MAPREDUCE-1112:
----------------------------------

    Attachment: MAPREDUCE-1112.2.patch

> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767174#action_12767174 ] 

Zheng Shao commented on MAPREDUCE-1112:
---------------------------------------

My bad. Yes it's the same as HADOOP-5759, except a file name change.

I will commit HADOOP-5759 to branch-0.20, and mark this one as duplicate.



> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch, MAPREDUCE-1112.2.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1112) Fix CombineFileInputFormat for hadoop 0.20

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766892#action_12766892 ] 

Zheng Shao commented on MAPREDUCE-1112:
---------------------------------------

MAPREDUCE-1112.1.patch changed the CombineFileInputFormat to implement InputFormat instead of FileInputFormat.
It is not backward compatible.

I will make CombineFileInputFormat inherits from FileInputFormat as before but just fix the bug of host name/rack name.


> Fix CombineFileInputFormat for hadoop 0.20
> ------------------------------------------
>
>                 Key: MAPREDUCE-1112
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1112
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1112.1.patch
>
>
> HADOOP-5759 is already fixed as a part of MAPREDUCE-364  in hadoop 0.21.
> This will fix the same problem with CombineFileInputFormat for hadoop 0.20.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.