You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/02 05:12:20 UTC

[jira] [Work logged] (TS-4808) General diagnostics cleanup.

     [ https://issues.apache.org/jira/browse/TS-4808?focusedWorklogId=27892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27892 ]

ASF GitHub Bot logged work on TS-4808:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Sep/16 05:12
            Start Date: 02/Sep/16 05:12
    Worklog Time Spent: 10m 
      Work Description: GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/959

    TS-4808: General diagnostics cleanup.

      - Clean up the Diags class to remove code duplication.
      - Switch all the diagnostic formatters over to using SourceLocation.
      - Remove useless mgmt_log functions which sometimes take stderr paramets.
      - Remove TSDiags() because it is awkward to pass a SourceLocation down.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/4808

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/959.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #959
    
----
commit 57e1374006c6b2bfe6aea0c9a8ca01f2af8875b1
Author: James Peach <jp...@apache.org>
Date:   2016-09-02T05:09:50Z

    TS-4808: General diagnostics cleanup.
    
      - Clean up the Diags class to remove code duplication.
      - Switch all the diagnostic formatters over to using SourceLocation.
      - Remove useless mgmt_log functions which sometimes take stderr paramets.
      - Remove TSDiags() because it is awkward to pass a SourceLocation down.

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 27892)
            Time Spent: 10m
    Remaining Estimate: 0h

> General diagnostics cleanup.
> ----------------------------
>
>                 Key: TS-4808
>                 URL: https://issues.apache.org/jira/browse/TS-4808
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core, Logging
>            Reporter: James Peach
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I started by noticing that {{RecDebug}} didn't emit the source location, and ended up shifting all the {{Diags}} code over to using {{SourceLocation}} and removing duplicated code in the diagnostic logging systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)