[GitHub] spark issue #13920: [SPARK-16166][Core] Also take off-heap memory usage into...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on the issue:

    https://github.com/apache/spark/pull/13920
  
    Sorry for the delay in reviewing; I've been super busy and stuff has slipped through the cracks. LGTM because this looks like a net improvement over what we have today. In the longer term I think that it might be slightly confusing to combine both on- and off-heap storage memory into a single total in the UI, but we can always deal with that later if it turns out to be a problem.
    
    Let me quickly re-test this to make sure that it still compiles and passes tests, then I'll merge it if Jenkins approves.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org