You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/12/13 00:33:53 UTC
Review Request 64558: Added a missing check for parent container has
config recovered.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64558/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Greg Mann.
Bugs: MESOS-8325
https://issues.apache.org/jira/browse/MESOS-8325
Repository: mesos
Description
-------
Added a missing check for parent container has config recovered.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp a67311734a7cd8155ba54fe9ac45b7a0e3312168
Diff: https://reviews.apache.org/r/64558/diff/1/
Testing
-------
make
Thanks,
Zhitao Li
Re: Review Request 64558: Added a missing check for parent container
has config recovered.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64558/#review193654
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Line 1723 (original), 1723 (patched)
<https://reviews.apache.org/r/64558/#comment272228>
This check is not needed since the check above is necessary.
- Gilbert Song
On Dec. 12, 2017, 4:33 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64558/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song and Greg Mann.
>
>
> Bugs: MESOS-8325
> https://issues.apache.org/jira/browse/MESOS-8325
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a missing check for parent container has config recovered.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp a67311734a7cd8155ba54fe9ac45b7a0e3312168
>
>
> Diff: https://reviews.apache.org/r/64558/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 64558: Added a missing check for parent container
has config recovered.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64558/#review193652
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/containerizer.cpp
Line 1716 (original), 1716 (patched)
<https://reviews.apache.org/r/64558/#comment272222>
Need to guard this `check`, right?
- Gilbert Song
On Dec. 12, 2017, 4:33 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64558/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 4:33 p.m.)
>
>
> Review request for mesos, Gilbert Song and Greg Mann.
>
>
> Bugs: MESOS-8325
> https://issues.apache.org/jira/browse/MESOS-8325
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a missing check for parent container has config recovered.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp a67311734a7cd8155ba54fe9ac45b7a0e3312168
>
>
> Diff: https://reviews.apache.org/r/64558/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 64558: Added a missing check for parent container
has config recovered.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64558/#review193638
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64558']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64558
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64558/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2516 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2539 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2484 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2508 ms total)
[----------] Global test environment tear-down
[==========] 829 tests from 84 test cases ran. (331078 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] SlaveTest.ResourceProviderPublishAll
10 FAILED TESTS
YOU HAVE 201 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64558/logs/mesos-tests-stderr.log):
```
I1213 02:34:55.545016 9280 master.cpp:10158] Updating the state of task 0fa8ae69-6c97-46a9-a870-2cf41f116606 of framework 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1213 02:34:55.545016 4464 slave.cpp:3400] Shutting down framework 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-0000
I1213 02:34:55.545994 4464 slave.cpp:6114] Shutting downI1213 02:34:54.812026 4816 exec.cpp:162] Version: 1.5.0
I1213 02:34:54.838026 6312 exec.cpp:237] Executor registered on agent 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-S0
I1213 02:34:54.841059 552 executor.cpp:171] Received SUBSCRIBED event
I1213 02:34:54.845744 552 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1213 02:34:54.846029 552 executor.cpp:171] Received LAUNCH event
I1213 02:34:54.850072 552 executor.cpp:637] Starting task 0fa8ae69-6c97-46a9-a870-2cf41f116606
I1213 02:34:54.946045 552 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1213 02:34:55.518997 552 executor.cpp:650] Forked command at 9448
I1213 02:34:55.547992 1312 exec.cpp:435] Executor asked to shutdown
I1213 02:34:55.547992 552 executor.cpp:171] Received SHUTDOWN event
I1213 02:34:55.547992 552 executor.cpp:747] Shutting down
I1213 02:34:55.547992 552 executor.cpp:854] Sending SIGTERM to process tree at pid 9 executor '0fa8ae69-6c97-46a9-a870-2cf41f116606' of framework 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-0000 at executor(1)@10.3.1.11:57572
I1213 02:34:55.546994 4464 slave.cpp:909] Agent terminating
W1213 02:34:55.546994 4464 slave.cpp:3396] Ignoring shutdown framework 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-0000 because it is terminating
I1213 02:34:55.547992 9280 master.cpp:10264] Removing task 0fa8ae69-6c97-46a9-a870-2cf41f116606 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-0000 on agent 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-S0 at slave(326)@10.3.1.11:57551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 02:34:55.549991 7216 containerizer.cpp:2329] Destroying container d01c28fc-12a4-45d1-82c1-f25c533bc34e in RUNNING state
I1213 02:34:55.549991 7216 containerizer.cpp:2931] Transitioning the state of container d01c28fc-12a4-45d1-82c1-f25c533bc34e from RUNNING to DESTROYING
I1213 02:34:55.549991 9280 master.cpp:1305] Agent 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-S0 at slave(326)@10.3.1.11:57551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1213 02:34:55.550994 9280 master.cpp:3364] Disconnecting agent 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-S0 at slave(326)@10.3.1.11:57551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 02:34:55.550994 9280 master.cpp:3383] Deactivating agent 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-S0 at slave(326)@10.3.1.11:57551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 02:34:55.550994 912 hierarchical.cpp:344] Removed framework 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-0000
I1213 02:34:55.550994 912 hierarchical.cpp:766] Agent 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-S0 deactivated
I1213 02:34:55.552086 7216 launcher.cpp:156] Asked to destroy container d01c28fc-12a4-45d1-82c1-f25c533bc34e
I1213 02:34:55.588218 9280 containerizer.cpp:2780] Container d01c28fc-12a4-45d1-82c1-f25c533bc34e has exited
I1213 02:34:55.617875 5216 master.cpp:1147] Master terminating
I1213 02:34:55.619902 4464 hierarchical.cpp:609] Removed agent 7ac45e93-4fc2-4f6a-87a9-a1f6cca2c5fb-S0
I1213 02:34:55.940615 4932 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 13, 2017, 12:33 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64558/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 12:33 a.m.)
>
>
> Review request for mesos, Gilbert Song and Greg Mann.
>
>
> Bugs: MESOS-8325
> https://issues.apache.org/jira/browse/MESOS-8325
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a missing check for parent container has config recovered.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp a67311734a7cd8155ba54fe9ac45b7a0e3312168
>
>
> Diff: https://reviews.apache.org/r/64558/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Zhitao Li
>
>