You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/11 01:28:28 UTC
[PR] refactor: convert grails-taglib to Groovy [grails-core]
borinquenkid opened a new pull request, #16594:
URL: https://github.com/apache/grails-core/pull/16594
## What
Converts the remaining Java sources of `grails-taglib` to Groovy: 34 `.java` files removed, 34 `.groovy` files added (42 files changed, 2629 insertions(+), 2597 deletions(-)).
## Why
The maintainers asked on #16351 for the Java-to-Groovy migration to land one Gradle project at a time as a stack of PRs, bottom-up in dependency order. #16572 did `grails-data-hibernate7`; this PR is 16 of 30 in the next stack (base: `refactor/java-to-groovy-grails-data-neo4j`). The end state of every file is taken from the `9.0.x-java-to-groovy` branch, which already carries the regression fixes found by CI.
Commits:
- 2ce0731bc8 build: configure the taglib jar duplicates exclusion lazily and say why
- 84f4f9e89c fix: keep the Java-facing API of the converted grails-taglib classes
- 44d6dd3fa8 refactor: convert grails-taglib to Groovy
## Changed outside the converted sources
- `M grails-gsp/grails-taglib/build.gradle`
## Java-facing API sweep
Every deleted `.java` was compared with its Groovy twin via `javap -v -protected` (class declaration, public/protected fields, constructors, methods incl. modifiers/throws/generics, interface default methods, nested class modifiers, and the annotations callers see). Result:
- `grails-taglib`: 34 deleted .java, 1 difference(s) found and fixed in this PR (see the `fix:` commit), 0 left
See also the notes below. Remaining informational entries (widened visibility, e.g. Groovy property accessors): 23.
## Verification
- `classes` and `testClasses` (plus `ast`/`cli`/`testFixtures` source sets where present) of the converted project(s) and of their direct dependents compile: ['grails-gsp', 'grails-gsp-core', 'grails-spring-security-oauth2', 'grails-web-taglib']
- No test suites were run locally (the umbrella branch was verified; CI runs them). `codeStyle`, `rat` and a whole-repo `build -PskipTests` are run once on the tip of the stack.
## Notes
- Informational sweep entries that are not regressions: Groovy enums gain `MIN_VALUE`/`MAX_VALUE`/`next()`/`previous()`, property accessors appear for formerly package-private members, nested static classes with implicit constructors become public (they were `protected`), and generic type parameters that Groovy erases in constructors/methods (descriptors identical).
- Groovy gotchas that applied (see #16351): `static final` without `public` creates a property; `==` calls `equals()`; Closure/SAM coercions; `@CompileStatic` with nested classes. All CI regression fixes found on the umbrella branch are included in the end state.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6278020910
**Temporary CI flag on this stacked branch (BLOCKER before merge).**
This Java-to-Groovy chain is a stack of PRs, and every push to any of them starts the full CI matrix, which is more runner time than the ASF allows us. Every PR in the stack except the one closest to its release branch (#16576) therefore carries one temporary commit, `CHANGEME FOR ACCEPTANCE`, that adds this to the root `gradle.properties`:
```
skipTests=true
skipCodeStyle=true
```
With it, CI on this PR compiles but does not run tests or code style. The full build runs on #16576 (closest to 10.0.x), and each PR gets it when the PR below it has merged.
**Condition for merging this PR:** that `gradle.properties` block (and the `CHANGEME FOR ACCEPTANCE` commit) must be dropped from this branch first, and CI must then be green with the tests running. A green check on this PR as it stands does not mean the tests ran. Rollout of the commit is branch by branch, so a branch may not carry it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6280547616
**Update: this branch now carries a different temporary CI commit (BLOCKER before merge).**
The earlier `skipTests`/`skipCodeStyle` flag in `gradle.properties` did not help enough: the functional jobs still compile the whole repository (about 57 minutes each) on every push, so it only saved around a fifth of the time. It has been removed.
In its place, every PR in this stack except #16576 (the one closest to 10.0.x) carries one temporary commit, `CHANGEME FOR ACCEPTANCE: disable PR workflow triggers`. It changes the `pull_request:` trigger of each workflow to `branches: ['CHANGEME-FOR-ACCEPTANCE']`, a branch that does not exist, so pushing, rebasing or force-pushing this branch starts no jobs.
**Condition for merging this PR:** that commit must be reverted on this branch first (`git revert` of the `CHANGEME FOR ACCEPTANCE` commit), and CI must then run and be green. **The absence of CI checks on this PR is deliberate and does not mean the code was tested.** The full build runs on #16576, and each PR gets it when the PR below it has merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6160075423
## ✅ All tests passed ✅
🏷️ Commit: 0f4f95adfb8936a266dae4a3c5eb382ec2c6d795
▶️ Tests: 98025 executed
⚪️ Checks: 85/85 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6138662550
## ✅ All tests passed ✅
🏷️ Commit: 736973ce4b2a796ca699c2eebb5181225a26e0d9
▶️ Tests: 100334 executed
⚪️ Checks: 85/85 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6199616366
## ✅ All tests passed ✅
🏷️ Commit: f37ba3088b1b423ec7119fb13bf679e87e35f467
▶️ Tests: 65061 executed
⚪️ Checks: 86/86 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.
borinquenkid commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6785708694
Moving this stacked draft to my fork (borinquenkid/grails-core, same branch name) to cut review noise while it is downstream of active work. The branch stays here and will be reopened upstream when it is ready to be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6208632997
## 🚨 All tests passed but jobs failed 🚨
### Failed Jobs without Test Failures
❌ [CI / Hibernate7 Functional Tests \(Java 21, indy\=false\)](https://github.com/apache/grails-core/actions/runs/38844247506/job/116791035743?pr=16594)
🏷️ Commit: 061756ccfce0bfa199ad93370ab952bf0d2ef961
▶️ Tests: 42987 executed
🟡 Checks: 33/80 completed
### Rerun Controls
Click the checkbox to trigger a rerun:
🔲 **Rerun jobs**
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6113254507
## 🚨 Jobs failed without executing tests 🚨
### Failed Jobs without Test Failures
❌ [CI / Build Grails-Core \(macOS JDK 21\)](https://github.com/apache/grails-core/actions/runs/38170639262/job/114562336500?pr=16594)
🏷️ Commit: 35e559ccfda3839c10c4541f0121323d6e9530e9
▶️ Tests: 0 executed
🟡 Checks: 5/79 completed
### Rerun Controls
Click the checkbox to trigger a rerun:
🔲 **Rerun jobs**
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6104469352
## 🚨 TestLens detected 1 failed test 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens CLI](https://testlens.app/docs/features/cli): `testlens pr 16594`
#### [CI / Build Grails-Core \(Windows JDK 25 shard 2\)](https://github.com/apache/grails-core/actions/runs/38101950445/job/114359528847?pr=16594) > :grails-startup-progress:test
| Test | Runs | Flakiness |
|---|---|--:|
| StartupProgressSpec > shows the tasks the application reports, to a browser signed in to see the details | ❌ | [5% 🟠](https://github.com/apache/grails-core/issues/16030) |
🏷️ Commit: 2ce0731bc809dee0ca68cbdc2d6f447d6342c705
▶️ Tests: 52646 executed
🟡 Checks: 33/78 completed
### Test Failures
<details><summary><strong>StartupProgressSpec > shows the tasks the application reports, to a browser signed in to see the details</strong> (:grails-startup-progress:test in <a href="https://github.com/apache/grails-core/actions/runs/38101950445/job/114359528847?pr=16594">CI / Build Grails-Core (Windows JDK 25 shard 2)</a>)</summary>
```
Condition failed with Exception:
pageLoad('/').body.contains('id="task"')
| |
null java.lang.NullPointerException: Cannot get property 'body' on null object
at org.apache.grails.startup.StartupProgressSpec.shows the tasks the application reports, to a browser signed in to see the details(StartupProgressSpec.groovy:837)
at org.apache.grails.startup.StartupProgressSpec.shows the tasks the application reports, to a browser signed in to see the details(StartupProgressSpec.groovy:837)
Caused by: java.lang.NullPointerException: Cannot get property 'body' on null object
... 1 more
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 StartupProgressSpec > shows the tasks the application reports, to a browser signed in to see the details <!-- uniqueId=[engine:spock]/[spec:org.apache.grails.startup.StartupProgressSpec]/[feature:$spock_feature_0_18] -->
Reuse successful test results:
🔲 ♻️ Only rerun the tests that failed or were muted before
Click the checkbox to trigger a rerun:
🔲 **Rerun jobs**
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.
borinquenkid closed pull request #16594: refactor: convert grails-taglib to Groovy
URL: https://github.com/apache/grails-core/pull/16594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6104632574
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16594?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `77.73109%` with `265 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 62.6776%. Comparing base ([`908abec`](https://app.codecov.io/gh/apache/grails-core/commit/908abecdae9c78e2df586d9825e312391a3a0648?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2ce0731`](https://app.codecov.io/gh/apache/grails-core/commit/2ce0731bc809dee0ca68cbdc2d6f447d6342c705?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16594?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...g/grails/taglib/encoder/OutputEncodingStack.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fencoder%2FOutputEncodingStack.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9lbmNvZGVyL091dHB1dEVuY29kaW5nU3RhY2suZ3Jvb3Z5) | 72.5888% | [46 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ails/taglib/AbstractTemplateVariableBinding.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FAbstractTemplateVariableBinding.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9BYnN0cmFjdFRlbXBsYXRlVmFyaWFibGVCaW5kaW5nLmdyb292eQ==) | 52.6316% | [35 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rails/taglib/index/TagLibraryIndexGenerator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Findex%2FTagLibraryIndexGenerator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9pbmRleC9UYWdMaWJyYXJ5SW5kZXhHZW5lcmF0b3IuZ3Jvb3Z5) | 72.8814% | [15 Missing and 17 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ovy/org/grails/taglib/index/TagLibraryIndex.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Findex%2FTagLibraryIndex.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9pbmRleC9UYWdMaWJyYXJ5SW5kZXguZ3Jvb3Z5) | 73.4513% | [15 Missing and 15 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/groovy/org/grails/taglib/TagMethodInvoker.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FTagMethodInvoker.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9UYWdNZXRob2RJbnZva2VyLmdyb292eQ==) | 83.6956% | [3 Missing and 12 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...src/main/groovy/org/grails/taglib/TagOutput.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FTagOutput.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9UYWdPdXRwdXQuZ3Jvb3Z5) | 77.2727% | [14 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/groovy/org/grails/taglib/TagBodyClosure.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FTagBodyClosure.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9UYWdCb2R5Q2xvc3VyZS5ncm9vdnk=) | 79.6296% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...y/org/grails/taglib/TemplateVariableBinding.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FTemplateVariableBinding.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9UZW1wbGF0ZVZhcmlhYmxlQmluZGluZy5ncm9vdnk=) | 77.7778% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...g/grails/taglib/index/TagLibraryIndexWriter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Findex%2FTagLibraryIndexWriter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9pbmRleC9UYWdMaWJyYXJ5SW5kZXhXcml0ZXIuZ3Jvb3Z5) | 76.7442% | [5 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/groovy/org/grails/taglib/TagLibraryLookup.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FTagLibraryLookup.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9UYWdMaWJyYXJ5TG9va3VwLmdyb292eQ==) | 85.1852% | [1 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## refactor/java-to-groovy-grails-data-neo4j #16594 +/- ##
====================================================================================
+ Coverage 43.8970% 62.6776% +18.7806%
- Complexity 859 30276 +29417
====================================================================================
Files 87 2216 +2129
Lines 4932 108822 +103890
Branches 879 20298 +19419
====================================================================================
+ Hits 2165 68207 +66042
- Misses 2415 31048 +28633
- Partials 352 9567 +9215
```
| [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16594?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...roovy/org/grails/taglib/GroovyPageTagWriter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FGroovyPageTagWriter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9Hcm9vdnlQYWdlVGFnV3JpdGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
| [...ls/taglib/encoder/OutputContextLookupHelper.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fencoder%2FOutputContextLookupHelper.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9lbmNvZGVyL091dHB1dENvbnRleHRMb29rdXBIZWxwZXIuZ3Jvb3Z5) | `75.0000% <100.0000%> (ø)` | |
| [...aglib/encoder/OutputEncodingStackAttributes.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fencoder%2FOutputEncodingStackAttributes.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9lbmNvZGVyL091dHB1dEVuY29kaW5nU3RhY2tBdHRyaWJ1dGVzLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
| [...oovy/org/grails/taglib/GroovyPageAttributes.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FGroovyPageAttributes.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9Hcm9vdnlQYWdlQXR0cmlidXRlcy5ncm9vdnk=) | `84.6154% <87.5000%> (ø)` | |
| [...ils/taglib/discovery/ReflectedTagMethodView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fdiscovery%2FReflectedTagMethodView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9kaXNjb3ZlcnkvUmVmbGVjdGVkVGFnTWV0aG9kVmlldy5ncm9vdnk=) | `93.7500% <93.7500%> (ø)` | |
| [...n/groovy/org/grails/taglib/TagMethodContext.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2FTagMethodContext.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9UYWdNZXRob2RDb250ZXh0Lmdyb292eQ==) | `76.1905% <86.6667%> (ø)` | |
| [...rg/grails/taglib/discovery/AstTagMethodView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fdiscovery%2FAstTagMethodView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9kaXNjb3ZlcnkvQXN0VGFnTWV0aG9kVmlldy5ncm9vdnk=) | `86.9565% <90.4762%> (ø)` | |
| [...g/grails/taglib/discovery/TagDiscoveryRules.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fdiscovery%2FTagDiscoveryRules.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9kaXNjb3ZlcnkvVGFnRGlzY292ZXJ5UnVsZXMuZ3Jvb3Z5) | `90.9091% <92.8571%> (ø)` | |
| [...g/grails/taglib/discovery/AstTagLibraryView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fdiscovery%2FAstTagLibraryView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9kaXNjb3ZlcnkvQXN0VGFnTGlicmFyeVZpZXcuZ3Jvb3Z5) | `68.1818% <82.3529%> (ø)` | |
| [...ls/taglib/discovery/ReflectedTagLibraryView.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree&filepath=grails-gsp%2Fgrails-taglib%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Ftaglib%2Fdiscovery%2FReflectedTagLibraryView.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWdzcC9ncmFpbHMtdGFnbGliL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL3RhZ2xpYi9kaXNjb3ZlcnkvUmVmbGVjdGVkVGFnTGlicmFyeVZpZXcuZ3Jvb3Z5) | `83.3333% <83.3333%> (ø)` | |
| ... and [16 more](https://app.codecov.io/gh/apache/grails-core/pull/16594?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2103 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16594/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6155689407
## ✅ All tests passed ✅
🏷️ Commit: 358ddec1a4dc83e3393feed1e7f94d76cd3030f9
▶️ Tests: 96832 executed
⚪️ Checks: 103/103 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: convert grails-taglib to Groovy [grails-core]
Posted by "testlens-app[bot] (via GitHub) via notifications" <no...@grails.apache.org>.
testlens-app[bot] commented on PR #16594:
URL: https://github.com/apache/grails-core/pull/16594#issuecomment-6607009480
## 🔎 No tests executed 🔎
🏷️ Commit: b5bc183a5283cf05230d859ade351ddc74920ad4
▶️ Tests: 0 executed
⚪️ Checks: 45/45 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org