[GitHub] [calcite] rubenada commented on a change in pull request #1307: [CALCITE-3182] Trim unused fields for plan of materialized-view before matching.

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1307: [CALCITE-3182] Trim unused fields for plan of materialized-view before matching.
URL: https://github.com/apache/calcite/pull/1307#discussion_r301069123
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
 ##########
 @@ -495,8 +495,9 @@ assert equalType(
     for (MutableRel targetDescendant : targetDescendants) {
       MutableRel queryDescendant = map.get(targetDescendant);
       if (queryDescendant != null) {
-        assert queryDescendant.rowType.equals(targetDescendant.rowType);
-        equivalents.put(queryDescendant, targetDescendant);
 
 Review comment:
   Sorry, @jinxing64 , I'm not familiar with this part of the code. So, you're saying that it's ok for the 'else' block here to be a no-op (and not for example, throwing an exception?). 
   Maybe a comment line will be helpful to explain the reason behind.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services