[cordova-paramedic] branch master updated: Add args to build command used for Saucelabs as well (#114)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git


The following commit(s) were added to refs/heads/master by this push:
     new 14bfac8  Add args to build command used for Saucelabs as well (#114)
14bfac8 is described below

commit 14bfac849985cbfc7d0c4840d2c2a5f328aac72c
Author: Guillermo Martínez <gm...@users.noreply.github.com>
AuthorDate: Mon Apr 15 11:05:48 2019 -0500

    Add args to build command used for Saucelabs as well (#114)
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    
    ### Motivation and Context
    <!-- Why is this change required? What problem does it solve? -->
    <!-- If it fixes an open issue, please link to the issue here. -->
    It fixes issue #113, it enables to run the plugin on SauceLabs.
    
    
    ### Description
    <!-- Describe your changes in detail -->
    Concatenation of the passed arguments using the `--args` flag.
    
    
    ### Testing
    <!-- Please describe in detail how you tested your changes. -->
    Running the following command and receiving success result,
    
    ```
    npx cordova-paramedic --platform ios --plugin ./ --shouldUseSauce --sauceUser ****** --sauceKey ********** --buildName "local cordova-paramedic test for ios"  --outputDir /tmp/junit --verbose --args=--buildFlag='-UseModernBuildSystem=0'
    ```
    
    
    ### Checklist
    
    - [X] I've run the tests to see all new and existing tests pass
    - [X] I added automated test coverage as appropriate for this change
    - [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
    - [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
    - [X] I've updated the documentation if necessary
    
    close #113
    
    Co-authored-by: Isaac Lopez <il...@nearsoft.com>
---
 lib/ParamedicSauceLabs.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/ParamedicSauceLabs.js b/lib/ParamedicSauceLabs.js
index df55b33..a15635f 100644
--- a/lib/ParamedicSauceLabs.js
+++ b/lib/ParamedicSauceLabs.js
@@ -565,7 +565,11 @@ class ParamedicSauceLabs {
 
     getCommandForBuilding () {
         const browserifyArg = this.config.isBrowserify() ? ' --browserify' : '';
-        return this.config.getCli() + ' build ' + this.platformId + browserifyArg + utilities.PARAMEDIC_COMMON_CLI_ARGS;
+        let cmd = this.config.getCli() + ' build ' + this.platformId + browserifyArg + utilities.PARAMEDIC_COMMON_CLI_ARGS;
+        if(this.config.getArgs()){
+            cmd += ' ' + this.config.getArgs();
+        }
+        return cmd;
     }
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org