[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1914: [CELEBORN-978] Improve dependency.sh replacement mode

["cxzl25 (via GitHub)" <gi...@apache.org>]

cxzl25 commented on code in PR #1914:
URL: https://github.com/apache/incubator-celeborn/pull/1914#discussion_r1325879829


##########
dev/dependencies.sh:
##########
@@ -186,6 +187,7 @@ case "$MODULE" in
     SBT_PROJECT="celeborn-client-flink-1_17"
     ;;
   *)
+    MODULE="server"

Review Comment:
   Because the `MODULE` parameter is not required, `DEP` and `DEP_PR` may refer to the empty string `MODULE`.



##########
dev/dependencies.sh:
##########
@@ -37,10 +37,11 @@ DEP_PR=""
 DEP=""
 
 function mvn_build_classpath() {
-  $MVN -P$MODULE clean install -DskipTests -am -pl $MVN_MODULES
-  $MVN -P$MODULE dependency:build-classpath -am -pl $MVN_MODULES | \

Review Comment:
   When the specified `MODULE` does not exist in the maven profile and it is an empty string, the command will become strange.
   ```bash
   build/mvn -P clean install xx
   ```
   If MODULE specifies a value, we will get a WARNING like this.
   ```
   Warning:  The requested profile "server" could not be activated because it does not exist.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org