You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/26 06:59:51 UTC

[GitHub] KellenSunderland commented on a change in pull request #12358: Fix flaky test : test_ndarray.test_order

KellenSunderland commented on a change in pull request #12358:  Fix flaky test : test_ndarray.test_order
URL: https://github.com/apache/incubator-mxnet/pull/12358#discussion_r212816522
 
 

 ##########
 File path: tests/python/unittest/test_ndarray.py
 ##########
 @@ -709,10 +708,10 @@ def get_large_matrix():
     gt = gt_topk(large_matrix_npy, axis=1, ret_typ="indices", k=5, is_ascend=False)
     assert_almost_equal(nd_ret_topk, gt)
 
-    for dtype in [np.int16, np.int32, np.int64, np.float32, np.float64]:
+    for dtype in [np.int32, np.int64, np.float32, np.float64]:
         a_npy = get_values(ensure_unique=True, dtype=dtype)
-        a_nd = mx.nd.array(a_npy, ctx=ctx)
-
+        
+        a_nd = mx.nd.array(a_npy, ctx=ctx, dtype = dtype)
 
 Review comment:
   Nit: spacing around '=' inconsistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services