You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/30 03:36:16 UTC

[GitHub] [pulsar] sijie commented on pull request #8566: always remove message data size

sijie commented on pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566#issuecomment-735525502


   @MaiCw4J You mentioned the following in the description of this pull request.
   
   ```
   may cause the batchReceive() method to call hasEnoughMessagesForBatchReceive() to determine that the conditions are met, but there is not actually enough data in the queue!
   ```
   
   Can you write a unit test to reproduce the issue you described in using batchReceive? Then you can confirm if this change fixes the issue or not.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org