You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/28 09:06:42 UTC
[GitHub] [rocketmq] rushsky518 opened a new pull request #1749:
ResetOffsetByTimeCommand supports specified queue
rushsky518 opened a new pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749
ResetOffsetByTimeCommand supports specified queue:
`mqadmin.cmd resetOffsetByTime -n localhost:9876 -t TopicTest -i "0,1" -g group-name -s 2020-01-28#12:10:00:000`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] xujianhai666 commented on a change in pull request
#1749: ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#discussion_r386008890
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/offset/ResetOffsetByTimeCommand.java
##########
@@ -49,10 +50,18 @@ public Options buildCommandlineOptions(Options options) {
opt.setRequired(true);
options.addOption(opt);
+ opt = new Option("b", "broker", true, "set broker address");
+ opt.setRequired(false);
+ options.addOption(opt);
+
opt = new Option("t", "topic", true, "set the topic");
opt.setRequired(true);
options.addOption(opt);
+ opt = new Option("i", "queue", true, "set the queue, eg: 0,1");
Review comment:
use parameter q instead of i, which is understandable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1749:
ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#issuecomment-579155658
[](https://coveralls.io/builds/28427561)
Coverage decreased (-0.02%) to 50.881% when pulling **be01b2b4e122e1879455c2b1f3e0c01800c78f10 on rushsky518:reset_offset** into **dd943622573ece3bc44fea81c10aa6c42fa6991c on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1749:
ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#issuecomment-579155658
[](https://coveralls.io/builds/28374853)
Coverage decreased (-0.003%) to 50.899% when pulling **99dd8c4079feb7f0e49ce3eed43f36260271d493 on rushsky518:reset_offset** into **dd943622573ece3bc44fea81c10aa6c42fa6991c on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] xujianhai666 commented on a change in pull request
#1749: ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#discussion_r386008669
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/offset/ResetOffsetByTimeOldCommand.java
##########
@@ -119,7 +123,7 @@ public void execute(CommandLine commandLine, Options options, RPCHook rpcHook) t
}
defaultMQAdminExt.start();
- resetOffset(defaultMQAdminExt, consumerGroup, topic, timestamp, force, timeStampStr);
+ resetOffset(defaultMQAdminExt, consumerGroup, topic, null, timestamp, force, timeStampStr);
Review comment:
null? maybe mistake. I thought u should convey paramater queue, but u not get queue from commandLine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1749:
ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#issuecomment-579155658
[](https://coveralls.io/builds/29046012)
Coverage decreased (-0.07%) to 50.837% when pulling **b7f944acaf01b871ba10786306c578a368b2d8f5 on rushsky518:reset_offset** into **dd943622573ece3bc44fea81c10aa6c42fa6991c on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] rushsky518 closed pull request #1749:
ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
rushsky518 closed pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1749:
ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#issuecomment-579155658
[](https://coveralls.io/builds/28477609)
Coverage increased (+0.05%) to 50.955% when pulling **a781b1286170d6b2cd221dec68410c08be5db1ea on rushsky518:reset_offset** into **dd943622573ece3bc44fea81c10aa6c42fa6991c on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1749:
ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#issuecomment-579155658
[](https://coveralls.io/builds/28371246)
Coverage decreased (-0.06%) to 50.846% when pulling **95fa3a83d2bdcbee1aefe03f72cf913ddd4c9bf3 on rushsky518:reset_offset** into **dd943622573ece3bc44fea81c10aa6c42fa6991c on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] rushsky518 opened a new pull request #1749:
ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
rushsky518 opened a new pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749
ResetOffsetByTimeCommand supports specified queue:
`mqadmin.cmd resetOffsetByTime -n localhost:9876 -b localhost:10911 -t TopicTest -i "0,1" -g group-name -s 2020-01-28#12:10:00:000`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] xujianhai666 commented on a change in pull request
#1749: ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#discussion_r386006945
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/offset/ResetOffsetByTimeCommand.java
##########
@@ -31,6 +29,9 @@
import org.apache.rocketmq.tools.command.SubCommand;
import org.apache.rocketmq.tools.command.SubCommandException;
+import java.util.Iterator;
Review comment:
java package should be first order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] xujianhai666 commented on a change in pull request
#1749: ResetOffsetByTimeCommand supports specified queue
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #1749: ResetOffsetByTimeCommand supports specified queue
URL: https://github.com/apache/rocketmq/pull/1749#discussion_r386007828
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/offset/ResetOffsetByTimeOldCommand.java
##########
@@ -82,6 +82,10 @@ public Options buildCommandlineOptions(Options options) {
opt.setRequired(true);
options.addOption(opt);
+ opt = new Option("i", "queue", true, "set the queue, eg: 0,1");
Review comment:
why not use -q ? q is short name of queue, which is understandable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services