You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sarahyurick (via GitHub)" <gi...@apache.org> on 2023/03/14 21:38:31 UTC
[GitHub] [arrow-datafusion] sarahyurick opened a new pull request, #5605: Change `&self` to `&mut self` in `try_optimize`
sarahyurick opened a new pull request, #5605:
URL: https://github.com/apache/arrow-datafusion/pull/5605
Closes https://github.com/apache/arrow-datafusion/issues/5583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sarahyurick commented on pull request #5605: Change `&self` to `&mut self` in `try_optimize`
Posted by "sarahyurick (via GitHub)" <gi...@apache.org>.
sarahyurick commented on PR #5605:
URL: https://github.com/apache/arrow-datafusion/pull/5605#issuecomment-1470591475
Closing after discussion in https://github.com/apache/arrow-datafusion/issues/5583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sarahyurick commented on pull request #5605: Change `&self` to `&mut self` in `try_optimize`
Posted by "sarahyurick (via GitHub)" <gi...@apache.org>.
sarahyurick commented on PR #5605:
URL: https://github.com/apache/arrow-datafusion/pull/5605#issuecomment-1468881985
I was having trouble getting the
https://github.com/apache/arrow-datafusion/blob/4d07360e6f67012571237ab1a773ac1fec7122d9/datafusion/optimizer/src/optimizer.rs#L347
function to work because `rule` is a `&Arc<dyn OptimizerRule + Send + Sync>`. I was wondering if I could receive any guidance on how to go about this since the `Arc` generates an error (`trait DerefMut is required to modify through a dereference`), but I don't think it should be changed to a `Mutex`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sarahyurick closed pull request #5605: Change `&self` to `&mut self` in `try_optimize`
Posted by "sarahyurick (via GitHub)" <gi...@apache.org>.
sarahyurick closed pull request #5605: Change `&self` to `&mut self` in `try_optimize`
URL: https://github.com/apache/arrow-datafusion/pull/5605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org