Workaround for transient id in ISIS-1341

[Willie Loyd Tandingan <ta...@gmail.com>]

We're trying out 1.12.0 to remove the manual flush workaround stated in
ISIS-1341 in our actions. The problem is that even though the transactions
are explicitly flushed in DomainResourceHelper before generating the
representations, transient ids are still being used since the OID is
generated at the point where the object adapter is being made for the
result and the flushing in DomainResourceHelper doesn't update it.

At the moment, we're still retaining the manual flushes in our actions
right before the action ends.

Best regards,
Willie

Re: Workaround for transient id in ISIS-1341

[Dan Haywood <da...@haywood-associates.co.uk>]

Just closing off this thread... trying this out in 1.13.0-SNAPSHOT,
somewhere along the line this now (seems to) automatically flush the
changes.  At any rate, I'm not seeing transient oids when I invoke
SimpleObjects#create.

Gonna assume this is now fixed, unless hear to the otherwise.

Thx
Dan



On 11 April 2016 at 09:33, Dan Haywood <da...@haywood-associates.co.uk> wrote:

> Ok, thanks for reporting this.
>
> Could you provide a simple example on github that demonstrates the
> problem?
>
> Meanwhile, a possible workaround might be to provide your own
> implementation of the RepresentationService that just subclasses the
> default imps but calls flush before invoking super.xxx()
>
> Dan
> On 11 Apr 2016 8:34 am, "Willie Loyd Tandingan" <ta...@gmail.com>
> wrote:
>
>> We're trying out 1.12.0 to remove the manual flush workaround stated in
>> ISIS-1341 in our actions. The problem is that even though the transactions
>> are explicitly flushed in DomainResourceHelper before generating the
>> representations, transient ids are still being used since the OID is
>> generated at the point where the object adapter is being made for the
>> result and the flushing in DomainResourceHelper doesn't update it.
>>
>> At the moment, we're still retaining the manual flushes in our actions
>> right before the action ends.
>>
>> Best regards,
>> Willie
>>
>

Re: Workaround for transient id in ISIS-1341

[Dan Haywood <da...@haywood-associates.co.uk>]

Ok, thanks for reporting this.

Could you provide a simple example on github that demonstrates the problem?

Meanwhile, a possible workaround might be to provide your own
implementation of the RepresentationService that just subclasses the
default imps but calls flush before invoking super.xxx()

Dan
On 11 Apr 2016 8:34 am, "Willie Loyd Tandingan" <ta...@gmail.com>
wrote:

> We're trying out 1.12.0 to remove the manual flush workaround stated in
> ISIS-1341 in our actions. The problem is that even though the transactions
> are explicitly flushed in DomainResourceHelper before generating the
> representations, transient ids are still being used since the OID is
> generated at the point where the object adapter is being made for the
> result and the flushing in DomainResourceHelper doesn't update it.
>
> At the moment, we're still retaining the manual flushes in our actions
> right before the action ends.
>
> Best regards,
> Willie
>