You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Ben Laurie <be...@algroup.co.uk> on 2000/03/19 14:09:28 UTC
Re: cvs commit: xml-cocoon/src/org/apache/cocoon/generators
DirectoryGenerator.java
stefano@locus.apache.org wrote:
>
> stefano 00/03/18 17:08:47
>
> Modified: src/org/apache/cocoon/generators Tag: xml-cocoon2
> DirectoryGenerator.java
> Log:
> first bugfix of the new tree :) Thanks to Giacomo for this!
Stefano,
Why do all your commits include blank line changes? Can it be avoided?
e.g...
> @@ -44,11 +44,11 @@
> this.contentHandler.startDocument();
> this.contentHandler.startPrefixMapping("",URI);
> AttributesImpl attr=new AttributesImpl();
> -
> +
> this.attribute(attr,"name",d.getName()+"/");
> this.start("directory",attr);
> this.data("\n");
> -
> +
> String c[]=d.list();
> for (int x=0; x<c.length; x++) {
> File f=new File(d,c[x]);
Nothing actually happened here!
Cheers,
Ben.
--
SECURE HOSTING AT THE BUNKER: http://www.thebunker.net/hosting.htm
http://www.apache-ssl.org/ben.html
Coming to ApacheCon Europe? http://ApacheCon.Com/
Re: cvs commit:
xml-cocoon/src/org/apache/cocoon/generatorsDirectoryGenerator.java
Posted by Pierpaolo Fumagalli <pi...@apache.org>.
Stefano Mazzocchi wrote:
>
> For example, I totally hate Pier's coding style since it's too
> "compressed" for my own taste... but he's lazy and types less than I do.
I'm not "lazy" :) I just pack the code :) That's why Jindent would be a
good solution... I code however I like and before doing a commint I just
reindend the whole stuff....
Pier (who about coding styles could not care less :)
--
----------------------------------------------------------------------
pier: stable structure erected over water to allow docking of seacraft
<ma...@betaversion.org> <http://www.betaversion.org/~pier/>
----------------------------------------------------------------------
Re: cvs commit:
xml-cocoon/src/org/apache/cocoon/generatorsDirectoryGenerator.java
Posted by Stefano Mazzocchi <st...@apache.org>.
Donald Ball wrote:
>
> On Sun, 19 Mar 2000, Paul Russell wrote:
>
> > On Sun, Mar 19, 2000 at 01:09:28PM +0000, Ben Laurie wrote:
> > > Stefano,
> > >
> > > Why do all your commits include blank line changes? Can it be avoided?
> > > e.g...
> > > > AttributesImpl attr=new AttributesImpl();
> > > > -
> > > > +
> > > > this.attribute(attr,"name",d.getName()+"/");
> > > Nothing actually happened here!
> >
> > It's almost certainly Stefano's text editor converting tabs to
> > spaces or vice verse. Not a lot that can be done, other than
> > using a text editor that, uh, doesn't.
>
> Or we all agree to use JStyle or something similar before committing to
> convert to an agreed upon standard...
Please, not again. In my years of open source this comes up once and a
while.... but no matter how hard you try to enforce your coding style,
people will break it or will complain about them.
So, for example, I like 4 spaces tabs for java and 2/1 spaces tabs for
XML... say something like this to, say, Linus and he'll shoot you dead.
Period.
I like Sun coding styles for java and my own coding style for XML (that
is: indented if nested element, not indented if nested but not block...
which really doesn't make any algorithmical sense at all since there is
no way to tell from a DTD what is a block and what's not... anyway) but
this doesn't mean everyone should do that.
For example, I totally hate Pier's coding style since it's too
"compressed" for my own taste... but he's lazy and types less than I do.
See... it's like imposing the music I like on you... or my religion...
or my operating system or my text editor.
We could try to make everyone happy, yes, but are you sure you have the
energy to fight religious wars?
I say, let's do our best to uniform to coding standards or stuff we've
been doing for years... everything else is just a detail.
--
Stefano Mazzocchi One must still have chaos in oneself to be
able to give birth to a dancing star.
<st...@apache.org> Friedrich Nietzsche
--------------------------------------------------------------------
Missed us in Orlando? Make it up with ApacheCON Europe in London!
------------------------- http://ApacheCon.Com ---------------------
Re: cvs commit:
xml-cocoon/src/org/apache/cocoon/generatorsDirectoryGenerator.java
Posted by Pierpaolo Fumagalli <pi...@apache.org>.
Donald Ball wrote:
>
> Or we all agree to use JStyle or something similar before committing to
> convert to an agreed upon standard...
That would be nice... URL ???
Pier
--
----------------------------------------------------------------------
pier: stable structure erected over water to allow docking of seacraft
<ma...@betaversion.org> <http://www.betaversion.org/~pier/>
----------------------------------------------------------------------
Re: cvs commit: xml-cocoon/src/org/apache/cocoon/generators
DirectoryGenerator.java
Posted by Donald Ball <ba...@webslingerZ.com>.
On Sun, 19 Mar 2000, Paul Russell wrote:
> On Sun, Mar 19, 2000 at 01:09:28PM +0000, Ben Laurie wrote:
> > Stefano,
> >
> > Why do all your commits include blank line changes? Can it be avoided?
> > e.g...
> > > AttributesImpl attr=new AttributesImpl();
> > > -
> > > +
> > > this.attribute(attr,"name",d.getName()+"/");
> > Nothing actually happened here!
>
> It's almost certainly Stefano's text editor converting tabs to
> spaces or vice verse. Not a lot that can be done, other than
> using a text editor that, uh, doesn't.
Or we all agree to use JStyle or something similar before committing to
convert to an agreed upon standard...
- donald
Re: cvs commit: xml-cocoon/src/org/apache/cocoon/generators DirectoryGenerator.java
Posted by Paul Russell <Pa...@uea.ac.uk>.
On Sun, Mar 19, 2000 at 01:09:28PM +0000, Ben Laurie wrote:
> Stefano,
>
> Why do all your commits include blank line changes? Can it be avoided?
> e.g...
> > AttributesImpl attr=new AttributesImpl();
> > -
> > +
> > this.attribute(attr,"name",d.getName()+"/");
> Nothing actually happened here!
It's almost certainly Stefano's text editor converting tabs to
spaces or vice verse. Not a lot that can be done, other than
using a text editor that, uh, doesn't.
Paul
Re: cvs commit: xml-cocoon/src/org/apache/cocoon/generators
DirectoryGenerator.java
Posted by Stefano Mazzocchi <st...@apache.org>.
Ben Laurie wrote:
>
> stefano@locus.apache.org wrote:
> >
> > stefano 00/03/18 17:08:47
> >
> > Modified: src/org/apache/cocoon/generators Tag: xml-cocoon2
> > DirectoryGenerator.java
> > Log:
> > first bugfix of the new tree :) Thanks to Giacomo for this!
>
> Stefano,
>
> Why do all your commits include blank line changes? Can it be avoided?
> e.g...
>
> > @@ -44,11 +44,11 @@
> > this.contentHandler.startDocument();
> > this.contentHandler.startPrefixMapping("",URI);
> > AttributesImpl attr=new AttributesImpl();
> > -
> > +
> > this.attribute(attr,"name",d.getName()+"/");
> > this.start("directory",attr);
> > this.data("\n");
> > -
> > +
> > String c[]=d.list();
> > for (int x=0; x<c.length; x++) {
> > File f=new File(d,c[x]);
>
> Nothing actually happened here!
Gee, sorry... didn't noticed that. I had my editor stripping out the
spaces... I'll stop right away. thanks for letting me know.
--
Stefano Mazzocchi One must still have chaos in oneself to be
able to give birth to a dancing star.
<st...@apache.org> Friedrich Nietzsche
--------------------------------------------------------------------
Missed us in Orlando? Make it up with ApacheCON Europe in London!
------------------------- http://ApacheCon.Com ---------------------
Re: cvs commit: xml-cocoon/src/org/apache/cocoon/generators
DirectoryGenerator.java
Posted by Pierpaolo Fumagalli <pi...@apache.org>.
Ben Laurie wrote:
>
> > @@ -44,11 +44,11 @@
> > this.contentHandler.startDocument();
> > this.contentHandler.startPrefixMapping("",URI);
> > AttributesImpl attr=new AttributesImpl();
> > -
> > +
> > this.attribute(attr,"name",d.getName()+"/");
> > this.start("directory",attr);
> > this.data("\n");
> > -
> > +
> > String c[]=d.list();
> > for (int x=0; x<c.length; x++) {
> > File f=new File(d,c[x]);
>
> Nothing actually happened here!
>
> Cheers,
>
> Ben.
Trailing white spaces trimmed, I believe... And CVS/diff is not smart
enough...
Pier
--
----------------------------------------------------------------------
pier: stable structure erected over water to allow docking of seacraft
<ma...@betaversion.org> <http://www.betaversion.org/~pier/>
----------------------------------------------------------------------