[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

[harshach <gi...@git.apache.org>]

Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1679#discussion_r82825994
  
    --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java ---
    @@ -266,26 +266,31 @@ private void doSeekRetriableTopicPartitions() {
                 if (offsetAndMeta != null) {
                     kafkaConsumer.seek(rtp, offsetAndMeta.offset() + 1);  // seek to the next offset that is ready to commit in next commit cycle
                 } else {
    -                kafkaConsumer.seekToEnd(toArrayList(rtp));    // Seek to last committed offset
    +                kafkaConsumer.seek(rtp, acked.get(rtp).committedOffset + 1);    // Seek to last committed offset
                 }
             }
         }
     
         // ======== emit  =========
         private void emit() {
    -        emitTupleIfNotEmitted(waitingToEmit.next());
    -        waitingToEmit.remove();
    +        while(!emitTupleIfNotEmitted(waitingToEmit.next()) && waitingToEmit.hasNext()) {
    +            waitingToEmit.remove();
    +        }
         }
     
    -    // emits one tuple per record
    -    private void emitTupleIfNotEmitted(ConsumerRecord<K, V> record) {
    +
    +    //Emits one tuple per record
    +    //@return true if tuple was emitted
    +    private boolean emitTupleIfNotEmitted(ConsumerRecord<K, V> record) {
             final TopicPartition tp = new TopicPartition(record.topic(), record.partition());
             final KafkaSpoutMessageId msgId = new KafkaSpoutMessageId(record);
     
             if (acked.containsKey(tp) && acked.get(tp).contains(msgId)) {   // has been acked
                 LOG.trace("Tuple for record [{}] has already been acked. Skipping", record);
    +            return false;
    --- End diff --
    
    why are we adding returns here. Having one return makes the method look cleaner. This is an if else conditions and we are returning false at the end.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---