You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "cryptoe (via GitHub)" <gi...@apache.org> on 2024/03/13 11:50:35 UTC
[PR] Adding more logging for s3 RetryableS3OutputStream (druid)
cryptoe opened a new pull request, #16117:
URL: https://github.com/apache/druid/pull/16117
Adding more logging for s3 RetryableS3OutputStream which would help us determine if chunk size needs to be adjusted .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Adding more logging for s3 RetryableS3OutputStream (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #16117:
URL: https://github.com/apache/druid/pull/16117#discussion_r1523104573
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -269,7 +269,12 @@ public void close() throws IOException
// Closeables are closed in LIFO order
closer.register(() -> {
// This should be emitted as a metric
- LOG.info("Total push time: [%d] ms", pushStopwatch.elapsed(TimeUnit.MILLISECONDS));
+ LOG.info(
+ "Total: %d parts has a push time: %d ms with cumulative size: %d bytes ",
Review Comment:
```suggestion
"Pushed total [%d] parts containing [%d] bytes in [%d]ms.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Adding more logging for s3 RetryableS3OutputStream (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #16117:
URL: https://github.com/apache/druid/pull/16117#discussion_r1523104573
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -269,7 +269,12 @@ public void close() throws IOException
// Closeables are closed in LIFO order
closer.register(() -> {
// This should be emitted as a metric
- LOG.info("Total push time: [%d] ms", pushStopwatch.elapsed(TimeUnit.MILLISECONDS));
+ LOG.info(
+ "Total: %d parts has a push time: %d ms with cumulative size: %d bytes ",
Review Comment:
```suggestion
"Total [%d] parts with total [%d] bytes pushed in [%d]ms.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Adding more logging for s3 RetryableS3OutputStream (druid)
Posted by "LakshSingla (via GitHub)" <gi...@apache.org>.
LakshSingla merged PR #16117:
URL: https://github.com/apache/druid/pull/16117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Adding more logging for s3 RetryableS3OutputStream (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on code in PR #16117:
URL: https://github.com/apache/druid/pull/16117#discussion_r1523143722
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -269,7 +269,12 @@ public void close() throws IOException
// Closeables are closed in LIFO order
closer.register(() -> {
// This should be emitted as a metric
- LOG.info("Total push time: [%d] ms", pushStopwatch.elapsed(TimeUnit.MILLISECONDS));
+ LOG.info(
+ "Total: %d parts has a push time: %d ms with cumulative size: %d bytes ",
Review Comment:
I like this better. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org