[GitHub] [apisix] gy09535 commented on issue #2098: bug: route use limit-count plugin, update again plugin config info not effective

[GitBox <gi...@apache.org>]

gy09535 commented on issue #2098:
URL: https://github.com/apache/apisix/issues/2098#issuecomment-680040446


   
   
   
   
   > welcome PR to fix this issue
   
   I think there has two problems, the 'changed' variable is always nil, Because when the 'route_config' is changed ,  it become a new key ,so the  'changed' variable  is always nil. Another problem is the 'route.modifiedIndex' is 'service.modifiedIndex', But the service is not changed, According to the code: https://github.com/apache/apisix/blob/master/apisix/plugin.lua#L297 .
   
   
   I changed the cache key to 'route_conf.modifiedIndex .. service_conf.modifiedIndex'  , a new value will be used whatever  the route or service has changed ,and also change the  'new_conf.modifiedIndex'  property as 'route_conf.modifiedIndex' (actually the service 'modifiedIndex') .
   
   According to this PR: https://github.com/apache/apisix/pull/2121


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org